Skip to content

Logging lesson number at the beginning of training #5199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

vincentpierre
Copy link
Contributor

Proposed change(s)

Add a method to EnvironmentParameterManager to log the current lesson number. This method can later be expanded to use another type of logging (currently just using logger.info)
Call this method at the start of training and when a lesson changes.

This results in the lesson being logged at the beginning of training, in addition to the current behavior which is to log only at lesson update.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@vincentpierre vincentpierre requested a review from andrewcoh March 30, 2021 17:15
@vincentpierre vincentpierre self-assigned this Mar 30, 2021
@vincentpierre vincentpierre merged commit c0ad675 into main Mar 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the develop-log-curriculum-lesson-number-at-start branch March 30, 2021 19:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants