Skip to content

Adding more tests for v2 models #5138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2021
Merged

Conversation

vincentpierre
Copy link
Contributor

Proposed change(s)

Added a test for the model parameter loader to check the new form of inputs.
Also reorganized the tests for inference in their own folder for clarity

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@vincentpierre vincentpierre self-assigned this Mar 16, 2021
@vincentpierre vincentpierre merged commit e6f55a2 into v2-staging Mar 17, 2021
@delete-merged-branch delete-merged-branch bot deleted the more-tests-for-v2-models branch March 17, 2021 17:03
surfnerd pushed a commit that referenced this pull request Mar 18, 2021
* Adding more tests for v2 models

* formatting

* fixing formatting
surfnerd pushed a commit that referenced this pull request Mar 18, 2021
* Adding more tests for v2 models

* formatting

* fixing formatting
surfnerd pushed a commit that referenced this pull request Mar 18, 2021
* Adding more tests for v2 models

* formatting

* fixing formatting
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants