Skip to content

[poca] Remove add_groupmate_rewards from settings #5082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

ervteng
Copy link
Contributor

@ervteng ervteng commented Mar 11, 2021

Proposed change(s)

Remove the add_groupmate_rewards flag from settings.py, as it should not be user-configurable. Instead, there is a public variable on the ExtrinsicRewardProvider that is set by POCA after creation.

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@ervteng ervteng mentioned this pull request Mar 11, 2021
10 tasks
@ervteng ervteng merged commit 8511f9f into develop-coma2-trainer Mar 11, 2021
@delete-merged-branch delete-merged-branch bot deleted the develop-extrinsic-flag branch March 11, 2021 15:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant