cleanup some mypy types #5072
Merged
cleanup some mypy types #5072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
commented
Mar 10, 2021
| @@ -253,9 +253,7 @@ def create_torch_policy( | |||
| return policy | |||
|
|
|||
| def create_coma_optimizer(self) -> TorchCOMAOptimizer: | |||
| return TorchCOMAOptimizer( # type: ignore | |||
There was a problem hiding this comment.
These made me sad :(
andrewcoh
reviewed
Mar 10, 2021
| @@ -58,7 +58,7 @@ def __init__( | |||
| PPOSettings, self.trainer_settings.hyperparameters | |||
| ) | |||
| self.seed = seed | |||
| self.policy: Policy = None # type: ignore | |||
| self.policy: TorchPolicy = None # type: ignore | |||
There was a problem hiding this comment.
I guess this still throws a mypy error?
There was a problem hiding this comment.
The # type: ignore is to handle it being assigned None - otherwise you'd have to use Optional[TorchPolicy] and check that it was non-None everywhere you used it.
andrewcoh
approved these changes
Mar 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Small mypy cleanup (IMHO)