Skip to content

[Verified] Backport analytics events #4892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 29, 2021

Conversation

chriselion
Copy link
Contributor

@chriselion chriselion commented Jan 29, 2021

Proposed change(s)

This backports (some of the) the analytics events changes in

Notable changes:

  • Training analytics does not contain the python side events (TrainingEnvironmentInitializedEvent and TrainingBehaviorInitializedEvent). This is because the verified package should use the older python library.
  • The "ActionSpec" nested fields are the same, but they are generated from a BrainParameters instead.
  • The IBuiltInSensor interface can't be added, so determining the enum value is done in an extension method that just checks the possible classes.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

https://jira.unity3d.com/browse/MLA-1739

Types of change(s)

  • New feature (OK'ed by release management to add in a patch release)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)

@chriselion chriselion requested a review from surfnerd January 29, 2021 01:38
@@ -2,34 +2,64 @@


def main():
asset_path = "Project/Assets"
asset_paths = [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just copied from master. This would have caught the fact that I forgot Analytics.meta file.

/// </summary>
/// <param name="sensor"></param>
/// <returns></returns>
public static BuiltInSensorType GetBuiltInSensorType(this ISensor sensor)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yum yum

@chriselion chriselion merged commit 93d7581 into release_2_verified Jan 29, 2021
@surfnerd surfnerd deleted the release_2_verified-analytics branch February 25, 2021 20:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants