make sure DefaultTrainerDict is pickle-able#4842
Merged
Merged
Conversation
Contributor
Author
|
Without the fix, the added test fails: def test_pickle():
# Make sure RunOptions is pickle-able.
run_options = RunOptions()
p = pickle.dumps(run_options)
> pickle.loads(p)
ml-agents/mlagents/trainers/tests/test_settings.py:526:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = DefaultTrainerDict(<class 'mlagents.trainers.settings.TrainerSettings'>, {})
args = (<class 'mlagents.trainers.settings.TrainerSettings'>,)
def __init__(self, *args):
> super().__init__(TrainerSettings, *args)
E TypeError: 'type' object is not iterable
ml-agents/mlagents/trainers/settings.py:684: TypeError |
ervteng
approved these changes
Jan 11, 2021
ervteng
reviewed
Jan 11, 2021
| def __init__(self, *args): | ||
| super().__init__(TrainerSettings, *args) | ||
| # Depending on how this is called, args may have the defaultdict | ||
| # callable at the start of the list or not. |
Contributor
There was a problem hiding this comment.
Maybe add a note about how it addresses an issue with pickle load for posterity
Contributor
Author
|
only change between the last commit and the previous one was adding a comment, so going to merge without tests finishing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
In the current form, the DefaultTrainerDict can't be deserialized from pickle (and thus can't be passed to a worker process from the subprocess module, which I'm trying to do in #4780). It appears that the initializer needs to be able to take both forms of arguments; I'm not sure if there's a cleaner way to do this.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Added in #4448
Types of change(s)
Checklist