Skip to content

[DO NOT MERGE] New memory abstraction and AMRL implementation #4374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from

Conversation

ervteng
Copy link
Contributor

@ervteng ervteng commented Aug 17, 2020

Proposed change(s)

New memory layer abstraction that lets a memory define it's memory size (w.r.t. the "memory size" specified in the config). Then the ActorCritic has a memory_size property which the Policy uses to set it's internal m_size. This allows the actual m_size that is used during training to be different than what is specified in the YAML. We might want to do this, for instance, if we want memory_size: 64 to mean the Policy has a memory size of 64, but the Critic network has memory size of 64 (total of 128) - so the Policy object can store both during training, but only export 64 for inference.

Also an implementation of https://openreview.net/forum?id=Bkl7bREtDr using this abstraction.

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@ervteng ervteng mentioned this pull request Aug 18, 2020
10 tasks
@ervteng
Copy link
Contributor Author

ervteng commented Sep 14, 2020

Outdated - develop-amrl has the latest experimental code.

@ervteng ervteng closed this Sep 14, 2020
@ervteng ervteng deleted the develop-add-fire-amrl branch September 14, 2020 17:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant