[refactor] Remove references to brain_name in policy #4134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewcoh
reviewed
Jun 18, 2020
| @@ -121,7 +121,7 @@ def export_model(self, name_behavior_id: str) -> None: | |||
| Exports the model | |||
| """ | |||
| policy = self.get_policy(name_behavior_id) | |||
| settings = SerializationSettings(policy.model_path, policy.brain.brain_name) | |||
There was a problem hiding this comment.
With PSankalp's change this stuff should go live in the policy anyways.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Removes all references to
BrainParameters.brain_namein policy.brain_nameis the only thing that's added toBehaviorSpecwhen making aBrainParameters, so this sets the stage for removal ofBrainParametersin Python.We also do some cleanup to move the validation of
memory_sizeto theattrsclass insettings.pyand correct incorrect documentation that saysmemory_sizemust be divisible by 4.Types of change(s)
Checklist
Other comments