UI for Ray stacks, rename WriteAdapter to ObservationWriter #3834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
commented
Apr 23, 2020
| @@ -112,7 +112,7 @@ public LayerMask RayLayerMask | |||
|
|
|||
| [HideInInspector, SerializeField, FormerlySerializedAs("observationStacks")] | |||
| [Range(1, 50)] | |||
| [Tooltip("Whether to stack previous observations. Using 1 means no previous observations.")] | |||
| [Tooltip("Number of raycast results that will be stacked before being fed to the neural network.")] | |||
chriselion
commented
Apr 23, 2020
| @@ -37,7 +37,7 @@ protected void OnRayPerceptionInspectorGUI(bool is3d) | |||
| // it is not editable during play mode. | |||
| EditorGUI.BeginDisabledGroup(!EditorUtilities.CanUpdateModelProperties()); | |||
| { | |||
| EditorGUILayout.PropertyField(so.FindProperty("m_ObservationStacks"), true); | |||
| EditorGUILayout.PropertyField(so.FindProperty("m_ObservationStacks"), new GUIContent("Stacked Raycasts"), true); | |||
mmattar
approved these changes
Apr 23, 2020
|
Yeah, it's hard to do the changelog with the PR number before you create the PR :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Updated the display name and tooltip for RayPerceptionSensorComponent's stacking slider:
(tooltip is copied BrainParameters.NumStackedVectorObservations).
Renamed WriteAdpater to ObservationWriter.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments