Skip to content

Add capabtilities checks to c# and python. #3831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2020
Merged

Add capabtilities checks to c# and python. #3831

merged 1 commit into from
Apr 24, 2020

Conversation

surfnerd
Copy link
Contributor

@surfnerd surfnerd commented Apr 23, 2020 •
edited
Loading

Proposed change(s)

Add a capabilities struct to dictate (in python and c#) which features are supported in a particular version of a package.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe) Adding a way for us to check the capabilities between C# and Python by having each pass a message to the other about their current capabilities.

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@surfnerd surfnerd force-pushed the master-capabilities branch from cf6b50f to b81e104 Compare April 23, 2020 23:54
@surfnerd surfnerd changed the title Add capabtilities proto message. Add capabtilities checks to c# and python. Apr 24, 2020
@surfnerd surfnerd force-pushed the master-capabilities branch from 7045da7 to 0311ab2 Compare April 24, 2020 00:25
@surfnerd surfnerd marked this pull request as ready for review April 24, 2020 00:27
surfnerd
surfnerd commented Apr 24, 2020
View reviewed changes
chriselion
chriselion reviewed Apr 24, 2020
View reviewed changes
chriselion
chriselion reviewed Apr 24, 2020
View reviewed changes
chriselion
chriselion reviewed Apr 24, 2020
View reviewed changes
@surfnerd surfnerd force-pushed the master-capabilities branch from 7d1ba73 to 2039059 Compare April 24, 2020 02:57
@surfnerd surfnerd requested a review from chriselion April 24, 2020 03:07
@surfnerd surfnerd self-assigned this Apr 24, 2020
@surfnerd surfnerd merged commit ffd53b5 into master Apr 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the master-capabilities branch April 24, 2020 14:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chriselion chriselion chriselion approved these changes

Assignees

@surfnerd surfnerd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@surfnerd @chriselion