Skip to content

access to observations in Heuristic #3825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2020
Merged

Conversation

chriselion
Copy link
Contributor

@chriselion chriselion commented Apr 22, 2020

Proposed change(s)

Before some of the refactoring on Agent, it was possible to view the vector observations in the Heuristic method. This adds a new method to re-enable that.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

https://forum.unity.com/threads/ml-agents-v1-0-and-roadmap-update-mar-19-2020-discussion-thread.850099/#post-5617669

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

Copy link
Contributor

@vincentpierre vincentpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I like how the GetObservations can be used not only for Heuristic but for other things. I was thinking making GetObservations protected, but public is probably better.

@chriselion chriselion merged commit 8142aaf into master Apr 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the MLA-922-read-only-observations branch April 22, 2020 22:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants