Skip to content

inference seed, increment seed for ModelRunner #3823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 22, 2020
Merged

inference seed, increment seed for ModelRunner #3823

merged 2 commits into from
Apr 22, 2020

Conversation

chriselion
Copy link
Contributor

@chriselion chriselion commented Apr 22, 2020 •
edited
Loading

Proposed change(s)

  • Give users the ability to set the random seed for ModelRunner (currently it's always 0)
  • Offset the random seed for each ModelRunner, just to potentially avoid synced behavior between duplicated models
  • Set the inference seed from the trainer's seed.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

https://jira.unity3d.com/browse/MLA-880

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@chriselion chriselion merged commit b4efae8 into master Apr 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the MLA-880-ModelRunner-seed branch April 22, 2020 20:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vincentpierre vincentpierre vincentpierre approved these changes

@surfnerd surfnerd Awaiting requested review from surfnerd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriselion @vincentpierre