Skip to content

[bug-fix] Increase buffer size for SAC tests #3813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2020
Merged

[bug-fix] Increase buffer size for SAC tests #3813

merged 1 commit into from
Apr 20, 2020

Conversation

ervteng
Copy link
Contributor

@ervteng ervteng commented Apr 20, 2020

Proposed change(s)

Previously we were using a buffer size of 500 for SAC end-to-end tests. This was much too small for 2D and memory tests, causing some instability if the seeding of the test ever changed.

We increase the buffer size to 5000 to fix this.

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

@ervteng ervteng requested a review from andrewcoh April 20, 2020 19:14
@ervteng ervteng marked this pull request as ready for review April 20, 2020 20:21
@ervteng ervteng merged commit 3fed09d into master Apr 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the develop-sactestbuffer branch April 20, 2020 20:21
mmattar pushed a commit that referenced this pull request Apr 20, 2020
Squashed commit of the following:
72624f0 
commit 3fed09d
Author: Ervin T <ervin@unity3d.com>
Date:   Mon Apr 20 13:21:28 2020 -0700

    [bug-fix] Increase buffer size for SAC tests (#3813)

commit 99ed28e
Author: Ervin T <ervin@unity3d.com>
Date:   Mon Apr 20 13:06:39 2020 -0700

    [refactor] Run Trainers in separate threads (#3690)

commit 52b7d2e
Author: Chris Elion <chris.elion@unity3d.com>
Date:   Mon Apr 20 12:20:45 2020 -0700

    update upm-ci-utils source (#3811)

commit 89e4804
Author: Vincent-Pierre BERGES <vincentpierre@unity3d.com>
Date:   Mon Apr 20 12:06:59 2020 -0700

    Removing done from the llapi doc (#3810)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewcoh andrewcoh andrewcoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ervteng @andrewcoh