Skip to content

Making Gym a wrapper #3812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 21, 2020
Merged

Making Gym a wrapper #3812

merged 9 commits into from
Apr 21, 2020

Conversation

vincentpierre
Copy link
Contributor

Proposed change(s)

Renaming UnityEnv to UnityToGymWrapper and making it a real wrapper.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Alternative to #3801

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@vincentpierre vincentpierre self-assigned this Apr 20, 2020
@vincentpierre vincentpierre marked this pull request as ready for review April 20, 2020 23:15
@vincentpierre vincentpierre requested a review from andrewcoh April 21, 2020 16:47
@vincentpierre vincentpierre mentioned this pull request Apr 21, 2020
10 tasks
Copy link
Contributor

@chriselion chriselion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great minds think alike.

allow_multiple_visual_obs: bool = False,
):
"""
Environment initialization
:param environment_filename: The UnityEnvironment path or file to be wrapped in the gym.
:param worker_id: Worker number for environment.
:param unity_env: The Unity BaseEnv to be wrapped in the gym.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a note that the environment will be closed when the UnityToGymWrapper is closed.

@vincentpierre vincentpierre merged commit a6500a6 into master Apr 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the develop-renaming-llapi branch April 21, 2020 19:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants