Use SemVer to check communication compatibility between C# and Python #3760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

surfnerd merged 10 commits into master from master-semver-communication

Apr 9, 2020

Contributor

surfnerd commented Apr 8, 2020 •

edited

Loading

Proposed change(s)

Use SemVer to check communication compatibility between C# and Python.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

Checklist

Added tests that prove my fix is effective or that my feature works
Updated the changelog (if applicable)
~~- [ ] Updated the documentation (if applicable)~~
~~- [ ] Updated the migration guide (if applicable)~~

Other comments

surfnerd added 2 commits

April 8, 2020 15:44


          [communication] Bump communication API to 1.0.0, check that major ver…

441f4f6

…sions match.


          add test. Update Changelog.

b92abb8

surfnerd requested a review from chriselion

April 8, 2020 22:59

surfnerd self-assigned this


          Use version property.

181e75f

chriselion reviewed

View reviewed changes

com.unity.ml-agents/Runtime/Academy.cs Outdated Show resolved Hide resolved

chriselion reviewed

View reviewed changes

com.unity.ml-agents/Runtime/Communicator/RpcCommunicator.cs Outdated Show resolved Hide resolved

chriselion reviewed

View reviewed changes

com.unity.ml-agents/Tests/Editor/Communicator/RpcCommunicatorTests.cs Show resolved Hide resolved


          Update com.unity.ml-agents/Tests/Editor/Communicator/RpcCommunicatorT…

c3c668d

…ests.cs


to make it slightly interesting

Co-Authored-By: Chris Elion <chris.elion@unity3d.com>

chriselion reviewed

View reviewed changes

com.unity.ml-agents/Runtime/Communicator/RpcCommunicator.cs Outdated Show resolved Hide resolved

chriselion reviewed

View reviewed changes

ml-agents-envs/mlagents_envs/environment.py Outdated Show resolved Hide resolved


          Addres PR feedback. Add tests.

c2ddaac

surfnerd changed the title ~~Bump communication API to 1.0.0 in C# and Python. Use SemVer to check compatibility.~~ Use SemVer to check communication compatibility between C# and Python

surfnerd added 4 commits

April 9, 2020 15:12


          black format, fix parameter for function.

2ae000d


          Fix type hint.

7ba2a50


          Actually use the parameter instead of hard coded values.

98210fe


          Fix hard coded version.

c6e8939

surfnerd requested review from vincentpierre and chriselion

April 9, 2020 23:00

surfnerd commented

View reviewed changes

ml-agents-envs/mlagents_envs/environment.py Outdated Show resolved Hide resolved

chriselion reviewed

View reviewed changes

com.unity.ml-agents/Runtime/Communicator/RpcCommunicator.cs Outdated Show resolved Hide resolved

chriselion approved these changes

View reviewed changes


          Add more combinations of version tests. Move check for version compat…

43e6f17

…ibility outside of the initialization check.

surfnerd merged commit fe6a63f into master

delete-merged-branch bot deleted the master-semver-communication branch

April 9, 2020 23:36

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet