[refactor] CLI changes #3705
Merged
[refactor] CLI changes #3705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
March 27, 2020 10:50
ervteng
commented
Mar 28, 2020
|
|
||
|
|
||
| def handle_existing_directories( | ||
| model_path: str, summary_path: str, resume: bool, force: bool |
There was a problem hiding this comment.
note that summary_path isn't used yet but with consolidating all summaries into the same directory will be checked as well.
harperj
reviewed
Mar 30, 2020
harperj
approved these changes
Mar 30, 2020
| self.summary_writers[category] = tf.summary.FileWriter(filewriter_dir) | ||
|
|
||
| def _delete_all_events_files(self, directory_name: str) -> None: |
There was a problem hiding this comment.
Minor: could add some logging to make the user aware this is happening.
added 6 commits
March 30, 2020 14:30
…gents into develop-cliflags
…gents into develop-cliflags
andrewcoh
approved these changes
Mar 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
--trainthe default, and deprecate it (with warning message)--inferenceflag for inference mode--loadwith--resume--forceto overwrite these files.TODO: Doc changes, changelogUseful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
MLA-787
Types of change(s)
Checklist
Other comments