Remove space from Product Name for examples #3612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,7 +3,7 @@ | |||
| --- !u!129 &1 | |||
| PlayerSettings: | |||
| m_ObjectHideFlags: 0 | |||
| serializedVersion: 18 | |||
| serializedVersion: 15 | |||
There was a problem hiding this comment.
What version of Unity did you use? I don't think the serialization version should have changed.
There was a problem hiding this comment.
2018.4.9f1. I will update to the latest 2018.4.x once I am near a faster internet connection and re-generate this change.
There was a problem hiding this comment.
No need, I think 2018.4.9f1 works
chriselion
approved these changes
Mar 11, 2020
surfnerd
approved these changes
Mar 12, 2020
In #2588 it was suggested that the space in the Product Name for our example environments causes confusion when using a default build because of the need to escape the space in the build filename. This change removes the space from the Product Name in the project's player settings.
harperj
force-pushed
the
develop-productnamenospaces
branch
from
d5c0484 to
22ab5f9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2588 it was suggested that the space in the Product Name for
our example environments causes confusion when using a default build
because of the need to escape the space in the build filename.
This change removes the space from the Product Name in the project's
player settings.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
#2588
Types of change(s)
Minor settings change.
Checklist
Other comments