Made BehaviorType public and added the SetBehaviorType method #3572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
reviewed
Mar 5, 2020
| [Serializable] | ||
| public enum BehaviorType | ||
| { | ||
| Default, |
chriselion
reviewed
Mar 5, 2020
com.unity.ml-agents/Runtime/Agent.cs
Outdated
| @@ -363,6 +363,24 @@ void NotifyAgentDone(DoneReason doneReason) | |||
| m_Brain = m_PolicyFactory.GeneratePolicy(Heuristic); | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// Updates the type of behavior for the agent. | |||
| /// - Default : The Agent will use the remote process for decision making. | |||
There was a problem hiding this comment.
I'd say move these to the enum's comments
chriselion
reviewed
Mar 5, 2020
| public void SetBehaviorType(BehaviorType behaviorType) | ||
| { | ||
| m_PolicyFactory.m_BehaviorType = behaviorType; | ||
| m_Brain?.Dispose(); |
There was a problem hiding this comment.
Should we only do this if the old and new types are different?
… same value do nothing
chriselion
approved these changes
Mar 5, 2020
delete-merged-branch
bot
deleted the
develop-behavior-type-programatically
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Made BehaviorType public and added the SetBehaviorType method
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments