Skip to content

Hotfix on Gym and the notebooks #3496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 26, 2020
Merged

Hotfix on Gym and the notebooks #3496

merged 10 commits into from
Feb 26, 2020

Conversation

vincentpierre
Copy link
Contributor

Proposed change(s)

Gym was failing in single agent environments.
Revamped the notebooks a little bit

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

chriselion
chriselion reviewed Feb 26, 2020
View reviewed changes
@vincentpierre
Update notebooks/getting-started-gym.ipynb
72298c7 
Co-Authored-By: Chris Elion <chris.elion@unity3d.com>
chriselion
chriselion reviewed Feb 26, 2020
View reviewed changes
vincentpierre and others added 2 commits February 25, 2020 17:14
@vincentpierre
Trying to enforce nuget version
00ae4de
@vincentpierre
Update notebooks/getting-started-gym.ipynb
5156d4a 
Co-Authored-By: Chris Elion <chris.elion@unity3d.com>
chriselion
chriselion reviewed Feb 26, 2020
View reviewed changes
chriselion
chriselion approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@chriselion chriselion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We should probably update unit test for the case we saw this afternoon, but can do that after.

@vincentpierre vincentpierre merged commit eb2a4a1 into master Feb 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the hotfix-gym-notebook branch February 26, 2020 01:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chriselion chriselion chriselion approved these changes

@anupam-142857 anupam-142857 Awaiting requested review from anupam-142857

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincentpierre @chriselion