-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Develop Side Channels tutorial #3391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
2eb1cfc
Making Register side channel a public method on the Academy
vincentpierre ae790e1
Adding a new tutorial on how to use side channels
vincentpierre a6c9002
Update docs/Python-API.md
vincentpierre 8fc90a3
Add a Deregister method
vincentpierre bd03b6e
Add the deregister to the example
vincentpierre 031d97b
Update com.unity.ml-agents/Runtime/Academy.cs
vincentpierre b956ff6
Update docs/Python-API.md
vincentpierre 8cb514d
Re-test
vincentpierre 60faecf
Renaming Deregister to Unregister
vincentpierre 04d87dd
Update docs/Python-API.md
vincentpierre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this code (and RegisterStringLogSideChannel ) should be an actual .cs file in the Examples directory. Otherwise it's way too easy for it to get out of date during refactors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW we might be able to populate the package docs based on code; there's a thread I started here https://unity.slack.com/archives/C070VFPRV/p1575917230249200
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(this critique isn't specific to this example, large blocks of uncompiled unexecuted code always makes me nervous; see also the jupyter notebook)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very fair concern. I would like to have a tutorial rather than code because I would like users to make their own rather than rely on our own implementations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would solve the problem if there was a way to show code from a file in
md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a block of markdown code and actual .cs file are equally likely to get copy-pasted. If it's in the Examples and not the SDK, we're free to change the implementation later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think links from the docs to the .cs and vice versa is sufficient for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather keep the code in there. I would argue that If I add the
.cs
script in the Examples folder, it will still be untested code. If I add the.cs
I would have to add the python code as well and we do not have a place to put this code right now (I do not want to put if in yet another notebook).I do agree that it is very bad to have large amount of code in markdown as tutorial (looking at you RollerBall) but I do not think I like the alternative. Maybe we should put a hold on this PR for now ?