Academy interface cleanup

[chriselion]

• Academy.LazyInitialization -> LazyInitialize (this was internal)
• Academy.IsAutomaticSteppingEnabled -> AutomaticSteppingEnabled and add setter. EnableAutomaticStepping made internal (DisableAutomaticStepping still public because is has an advanced option).
• Academy.GetEpisodeCount, GetStepCount, GetTotalStepCount ->EpisodeCount, StepCount, TotalStepCount properties

[chriselion]

@surfnerd Thoughts on this? I assume Object.Destroy() is generally preferable, but unit tests break if we do that instead of Object.DestroyImmediate()

[surfnerd]

Seems good since it's false by default.

[vincentpierre]

Why is DisableAutomaticStepping still public? Seems like there are now 2 ways to disable stepping

AutomaticSteppingEnabled = false;

and

DisableAutomaticStepping()

If it is to leave the option to destroy immediate or not, why do we need to be able to do both ?

[chriselion]

From the comments above:

I assume Object.Destroy() is generally preferable, but unit tests break if we do that instead of Object.DestroyImmediate()

Open to other suggestions on how to resolve this.

[vincentpierre]

What is wrong having DestroyImmediate be the only option?

[vincentpierre]

Or we could have this in the test :

        [Test]
        public void TestAcademyAutostep()
        {
            var aca = Academy.Instance;
            Assert.IsTrue(aca.IsAutomaticSteppingEnabled);
            UnityEngine.TestTools.LogAssert.Expect(LogType.Error, "Destroy may not be called from edit mode! Use DestroyImmediate instead.\nAlso think twice if you really want to destroy something in edit mode. Since this will destroy objects permanently.");
            aca.DisableAutomaticStepping(false);
            Assert.IsFalse(aca.IsAutomaticSteppingEnabled);
            aca.EnableAutomaticStepping();
            Assert.IsTrue(aca.IsAutomaticSteppingEnabled);
        }

[surfnerd]

DestroyImmediate is strongly recommended against since it tries to deallocate memory immediately instead of batching it together after a normal Destroy call.

[vincentpierre]

Should we make DisableAutomaticStepping internal (This way we can test it without exposing it?)

[chriselion]

DisableAutomaticStepping is now private; I use Application.isEditor to switch between Destroy and DestoryImmediate.