write observations directly to protobuf #3229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
commented
Jan 15, 2020
| @@ -592,7 +571,7 @@ void UpdateSensors() | |||
| /// <param name="buffer"> A float array that will be used as buffer when generating the observations. Must | |||
| /// be at least the same length as the total number of uncompressed floats in the observations</param> | |||
| /// <param name="adapter"> The WriteAdapter that will be used to write the ISensor data to the observations</param> | |||
| /// <param name="observations"> A list of observations outputs. This argument will be modified by this method.</param>// | |||
| /// <param name="observations"> A list of observations outputs. This argument will be modified by this method.</param>// | |||
| public static void GenerateSensorData(List<ISensor> sensors, float[] buffer, WriteAdapter adapter, List<Observation> observations) | |||
There was a problem hiding this comment.
Not removed here because the other PR needs it, but this gets rid of the calls to GenerateSensorData
chriselion
commented
Jan 15, 2020
| { | ||
| var numFloats = sensor.ObservationSize(); | ||
| var floatDataProto = new ObservationProto.Types.FloatData(); | ||
| // Resize the float array |
There was a problem hiding this comment.
Unfortunately, doesn't seem to be a way to set the Capacity on this.
There was a problem hiding this comment.
Actually, there is, but only in newer versions of the library: protocolbuffers/protobuf@da57400
There was a problem hiding this comment.
Added code comment on this too.
chriselion
changed the title
vincentpierre
approved these changes
Jan 15, 2020
| @@ -197,5 +189,40 @@ public static ObservationProto ToProto(this Observation obs) | |||
| obsProto.Shape.AddRange(obs.Shape); | |||
| return obsProto; | |||
| } | |||
|
|
|||
| public static ObservationProto GetObservationProto(this ISensor sensor, WriteAdapter writeAdapter) | |||
There was a problem hiding this comment.
Maybe a docstring on this ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vincentpierre This doesn't account for your recent change; let's talk about how to bring them together.