Always reset when agent is done #3222
Conversation
| m_VectorSensorBuffer = new float[sensors.GetSensorFloatObservationSize()]; | ||
| } | ||
|
|
||
| // This is a bit of a hack - if we're in inference mode, observations won't be generated |
There was a problem hiding this comment.
Copied comment doesn't make sense here.
…logies/ml-agents into develop-agentondone
| // This is a bit of a hack - if we're in inference mode, observations won't be generated | ||
| // But we need these to be generated for the recorder. So generate them here. | ||
| var observations = new List<Observation>(); | ||
| GenerateSensorData(sensors, m_VectorSensorBuffer, m_WriteAdapter, observations); |
There was a problem hiding this comment.
I'm confused - you said before that the problem was some of the agent sensors might not be availble for generation (e.g. camera already cleaned up). If that's the case, won't that still be a problem here? How's this different from passing the actual sensors to RequestDecision?
There was a problem hiding this comment.
We generate the data earlier. OnDisable is called first on all destroyed gameObjects and then On Destroy is called on all game objects.
We call GenerateSensorData in OnDisable rather than in the next fixed update.
There was a problem hiding this comment.
I'm generally confused about what this function is attempting to achieve.
|
Migration guide? Sounds OK otherwise. |
* fill 0s for done agents * docstrings
|
Re-requesting review since a lot changed |
vincentpierre
changed the title
Co-Authored-By: Chris Elion <chris.elion@unity3d.com>
In this PR:
AgentOnDonevirtual method on theAgentclassReset On Donecheckbox from theAgentinspectorFixedSensorthat takes as input anObservationand will always return that observation when calledIPolicywith a true done flag, a list ofFixedSensorand an empty callback.AgentOnDone