Fix issue with different decision intervals for different brains #3181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
reviewed
Jan 8, 2020
| ) | ||
| for name_behavior_id in step_info.name_behavior_ids: | ||
| if name_behavior_id not in self.managers: | ||
| continue |
There was a problem hiding this comment.
Should we warn and/or throw an exception here?
chriselion
approved these changes
Jan 8, 2020
Cool, let's wait for Andrew to take a look before merging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is more than one brain each with a different decision interval, only one of the brains would be updated. This was because we were checking if we had any actions present for each EnvironmentStep - and in the error case there would be no actions but still a braininfo present.
We now process all the steps, but don't withdraw previous step unless there is an action.