Fix mypy errors in trainer code. #3135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
December 30, 2019 12:29
chriselion
commented
Dec 30, 2019
| # repo: https://github.com/chriselion/mypy | ||
| # rev: 3d0b6164a9487a6c5cf9d144110b86600fd85e25 | ||
| # This is a fork with the assert disabled, although precommit has trouble installing it sometimes. | ||
| rev: v0.761 |
There was a problem hiding this comment.
Tried bumping this to get the errors to show, but no luck. Removed the obsolete comment.
chriselion
commented
Dec 30, 2019
| @@ -206,7 +206,7 @@ def update( | |||
| return update_stats | |||
|
|
|||
| def update_reward_signals( | |||
| self, reward_signal_minibatches: Dict[str, Dict], num_sequences: int | |||
| self, reward_signal_minibatches: Mapping[str, Dict], num_sequences: int | |||
There was a problem hiding this comment.
This was getting Dict[str, AgentBuffer] passed to it, which causes the helpful errors:
ml-agents/mlagents/trainers/sac/trainer.py:322: note: "Dict" is invariant -- see http://mypy.readthedocs.io/en/latest/common_issues.html#variance
ml-agents/mlagents/trainers/sac/trainer.py:322: note: Consider using "Mapping" instead, which is covariant in the value type
chriselion
commented
Dec 30, 2019
| @@ -70,7 +70,7 @@ def __init__( | |||
| self.load = load | |||
| self.multi_gpu = multi_gpu | |||
| self.seed = seed | |||
| self.policy: TFPolicy = None | |||
| self.policy: PPOPolicy = None # type: ignore | |||
There was a problem hiding this comment.
Ignore the error of setting this to None, since we'll always set it to an instance before using.
andrewcoh
approved these changes
Dec 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.