Skip to content

Hotfix 0.4.0b #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 24, 2018
Merged

Hotfix 0.4.0b #1002

merged 6 commits into from
Jul 24, 2018

Conversation

awjuliani
Copy link
Contributor

  • Corrects observation space description for PushBlock environment.
  • Fixes bug preventing using environments with python multi-processing.
  • Fixes bug preventing agents to be initialized without a brain.

vincentpierre and others added 6 commits July 23, 2018 16:40
… the agent to avoid errors when the agent is initialized without a brain
…alization

[Hotfix] Removed the reference to the brain in the OnEnable method of…
…cessing

[Hotfix] Made the Pipe of the grpc communicator an instance property
@vincentpierre vincentpierre removed their request for review July 24, 2018 20:38
{
textureArray[i] = new Texture2D(brain.brainParameters.cameraResolutions[i].width,
brain.brainParameters.cameraResolutions[i].height, TextureFormat.RGB24, false);
textureArray[i] = new Texture2D(1, 1, TextureFormat.RGB24, false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason behind this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The agent can be initialized without a brain attached, in which case the old code would throw an error. In the new code we use the agent's camera list to initialize the texture2d array. But, since we don't know how big the textures should be, we initialize them to 1x1 to start with.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want to allow the agent be initialized without a brain attached?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to programmatically attach brains during runtime, as is the case with WallJump.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see.

@@ -15,7 +15,8 @@


class UnityToExternalServicerImplementation(UnityToExternalServicer):
parent_conn, child_conn = Pipe()
def __init__(self):
self.parent_conn, self.child_conn = Pipe()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the fix for the bug preventing using environments with python multi-processing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. In the old code they were global variables, which prevented multiple instances of them from being created correctly.

@awjuliani awjuliani merged commit 1ead1cc into master Jul 24, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants