Skip to content

Conversation

@vincentpierre
Copy link
Contributor

No description provided.

@vincentpierre vincentpierre requested a review from eshvk April 4, 2019 22:46
var buffer = System.Text.Encoding.ASCII.GetBytes(s);
this.size = buffer.Length;
this.bytes=new byte[64];
if (size> 64){
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this explicit and throw an error

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

}

[StructLayout(LayoutKind.Sequential)]
public struct char256 {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the generic approach not work? You commented out the code..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generic does not work because the size must be known at compile time.

// Time.captureFramerate = 60;

Spawn(100);
Spawn(10000);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The more the merrier.

public struct ShipSensor : IComponentData
{
[Reward]
// [Reward]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the Reward Attribute, only the Sensor Attribute remains. We can change that later but for now, only one sensor is simpler.

@vincentpierre vincentpierre merged commit 0f23c03 into master Apr 5, 2019
@vincentpierre vincentpierre deleted the experiment-reflection branch April 5, 2019 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants