Skip to content

Conversation

@CortiWins
Copy link

Purpose of this PR

Class: TextureMoveTool
Method: DoToolUI

Snapping is done by using EditorSnapping.MoveSnap on the moved position.

There are three handles

  • Slider2D
  • Slider1D Up ( Green arrow)
  • Slider1D Right (RedArrow)

The Slider2D has an explicit individual snap value of 0.0f. The Slider1Ds use a method override that internally applies -1.0f as a snap factor.

The position done via Slider1D is snapped to 1.0 increments before getting to the MoveSnap line where the actual snap settings are applied.

Class: TextureMoveTool
Method: DoToolUI

Snapping is done by using EditorSnapping.MoveSnap on the moved position.

There are three handles
- Slider2D
- Slider1D Up ( Green arrow)
- Slider1D Right (RedArrow)

The Slider2D has an explicit individual snap value of 0.0f.
The Slider1Ds use a method override that internally applies -1.0f as a snap factor.

The position done via Slider1D is snapped to 1.0 increments before getting to the MoveSnap line where the acutual snap settings are applied.
@u-pr-agent
Copy link

u-pr-agent bot commented Oct 23, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

The PR is a small, localized bug fix with a clear explanation, making it very straightforward to review.
🏅 Score: 95

The code change correctly fixes the snapping issue and improves readability, but there is a minor typo in the changelog entry.
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Changelog Entry

There appears to be a typo ("big" instead of "bug") in the new changelog entry. Also, the line starts with a + character which should probably be removed.

- Fixed a big where in the TextureMoveTool, a snapping of 1.0f was applied to handle movement before the actual snapping is applied

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant