Skip to content

Fix "New Shape" menu action always building a cube #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 26, 2020

Conversation

karl-
Copy link
Contributor

@karl- karl- commented Mar 23, 2020

The New Shape menu item now creates the last selected shape with it's last set parameters instead of always building a cube primitive with the default values.

@JoelFortin
Copy link
Contributor

Looks good but some questions arise for me :

  1. Now that the New Button takes whatever settings we left in the shape tool, should we also map the shortcut CTRL+K to do the same ? right now it still create a cube, so we have discrepancy between the two ways now.
  2. Now that I had to play with different shapes in short period of time, I would kill just to have a reset button for shape settings only in the shape window (there is a new reset option in the preferences but it's to high level and can reset options that I don't necessarily want to reset if I only need to wipe the shape data).
  3. Also noted if I have the shape tool opened and I perform a reset in the preferences, I see the update right away in the shape window but the preview object in the scene is still the one I had before the reset.

#1 should be addressed in this PR if we decide to match to behavior.
#2 is pretty much a feature request and should be treated separately

What do you think ?

@karl-
Copy link
Contributor Author

karl- commented Mar 24, 2020

Now that the New Button takes whatever settings we left in the shape tool, should we also map the shortcut CTRL+K to do the same ? right now it still create a cube, so we have discrepancy between the two ways now.

Cmd+K is mapped to the menu item Create ProBuilder Cube, so I think it makes sense that it remains as is. We don't have a shortcut for 'New Shape' by default, but one could be added if you think it's necessary here.

Now that I had to play with different shapes in short period of time, I would kill just to have a reset button for shape settings only in the shape window (there is a new reset option in the preferences but it's to high level and can reset options that I don't necessarily want to reset if I only need to wipe the shape data).

+1, added in bed79c3

Also noted if I have the shape tool opened and I perform a reset in the preferences, I see the update right away in the shape window but the preview object in the scene is still the one I had before the reset.

I wasn't able to find a good way to do this without modifying Settings Manager to provide a callback when things are reset. I will do that as future work.

@karl- karl- merged commit 75f53d5 into master Mar 26, 2020
@karl- karl- deleted the shapes/fix-new-shape-action-not-building-selected-shape branch March 26, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants