Merge branch 'test/multiprocess-tests/execute-step-in-context' into test/multiprocess-tests/adding-perf-tests-for-spawn

* test/multiprocess-tests/execute-step-in-context:
  Apply suggestions from code review
  fix/cleanup asmdefs again

Author: SamuelBellomo

com.unity.multiplayer.mlapi/Tests/Runtime/com.unity.multiplayer.mlapi.runtimetests.asmdef

@@ -8,6 +8,8 @@
     "optionalUnityReferences": [
         "TestAssemblies"
     ],
-    "includePlatforms": [],
-    "excludePlatforms": []
+    "defineConstraints": [
+        "UNITY_INCLUDE_TESTS",
+        "UNITY_EDITOR"
+    ]
 }

testproject/Assets/Tests/Runtime/MultiprocessRuntime/Helpers/MultiprocessOrchestration.cs

@@ -34,7 +34,7 @@ public static void StartWorkerNode()
                     workerNode.StartInfo.FileName = $"{buildPath}.exe";
                     break;
                 default:
-                    throw new NotImplementedException("StartWorkerNode: Current platform not supported");
+                    throw new NotImplementedException($"{nameof(StartWorkerNode)}: Current platform is not supported");
             }
         }
         catch (FileNotFoundException)
@@ -53,7 +53,7 @@ public static void StartWorkerNode()
             var newProcessStarted = workerNode.Start();
             if (!newProcessStarted)
             {
-                throw new Exception("Process not started!");
+                throw new Exception("Failed to start process!");
             }
         }
         catch (Win32Exception e)

testproject/Assets/Tests/Runtime/testproject.runtimetests.asmdef

@@ -1,25 +1,15 @@
 {
     "name": "TestProject.RuntimeTests",
-    "rootNamespace": "",
     "references": [
-        "Unity.Multiplayer.MLAPI.Runtime",
-        "Unity.Multiplayer.MLAPI.RuntimeTests",
         "TestProject.ManualTests",
-        "UnityEngine.TestRunner",
-        "UnityEditor.TestRunner"
+        "Unity.Multiplayer.MLAPI.Runtime",
+        "Unity.Multiplayer.MLAPI.RuntimeTests"
     ],
-    "includePlatforms": [],
-    "excludePlatforms": [],
-    "allowUnsafeCode": false,
-    "overrideReferences": true,
-    "precompiledReferences": [
-        "nunit.framework.dll"
+    "optionalUnityReferences": [
+        "TestAssemblies"
     ],
-    "autoReferenced": false,
     "defineConstraints": [
         "UNITY_INCLUDE_TESTS",
         "UNITY_EDITOR"
-    ],
-    "versionDefines": [],
-    "noEngineReferences": false
+    ]
 }