refactor!: remove network dictionary & set, use native container in List, add tests (#1149)

* refactor!: clean up network dictionary, use native containers
* added dirty list as native container
* remove set & dictionary
* list cleanup
* more tests
* rounded out xtors in NetworkList
* improved ienumerable, removed client writability
Co-authored-by: Andrew Spiering <andrews@unity3d.com>

Author: mattwalsh-unity

com.unity.netcode.gameobjects/Runtime/Core/NetworkBehaviour.cs

@@ -639,7 +639,7 @@ internal void HandleNetworkVariableDeltas(Stream stream, ulong clientId)
                     }
                 }
 
-                if (NetworkManager.IsServer && !NetworkVariableFields[i].CanClientWrite(clientId))
+                if (NetworkManager.IsServer)
                 {
                     // we are choosing not to fire an exception here, because otherwise a malicious client could use this to crash the server
                     if (NetworkManager.NetworkConfig.EnsureNetworkVariableLengthSafety)
@@ -824,5 +824,24 @@ protected NetworkObject GetNetworkObject(ulong networkId)
         {
             return NetworkManager.SpawnManager.SpawnedObjects.TryGetValue(networkId, out NetworkObject networkObject) ? networkObject : null;
         }
+
+        public void OnDestroy()
+        {
+            // this seems odd to do here, but in fact especially in tests we can find ourselves
+            //  here without having called InitializedVariables, which causes problems if any
+            //  of those variables use native containers (e.g. NetworkList) as they won't be
+            //  registered here and therefore won't be cleaned up.
+            //
+            // we should study to understand the initialization patterns
+            if (!m_VarInit)
+            {
+                InitializeVariables();
+            }
+
+            for (int i = 0; i < NetworkVariableFields.Count; i++)
+            {
+                NetworkVariableFields[i].Dispose();
+            }
+        }
     }
 }