fix: NetworkAnimator destinationStateMachine exception [MTT-5083] (#2309)

* fixes
This fixes the issue where NetworkAnimator was not taking into consideration `AnimatorStateTtansition.destinationStateMachine`.  Now, NetworkAnimator parses each destinationStateMachine's states for trigger transitions and includes those in the transition table.
passing setTrigger bool to internal method.

Fixed issue where the host client was receiving the ClientRpc animation updates when the host was the owner.

Fixed an issue with using pooled objects and when specific properties are cleaned during despawn and destroy.

This fixes the issue where NetworkAnimator was checking for animation changes when the associated NetworkObject was not spawned.

* update
Removed the AnimationSynchronizationData class as it really was not needed.
Adding UNITY_INCLUDE_TESTS define in the components AssemblyInfo.cs file.
This includes some updates to NetworkAnimator that will remove the need to synchronize client's using RPCs but instead use the new OnSynchronize method.

* test manual
Updated the NetworkAnimator manual test that provides a way to validate this fix visually.
Minor fix for weapon attack option in manual test.

* test
Updating test to validate states defined within a destinationStateMachine are triggering.

Made components visible to testproject again although I might try to figure out a better way to handle these two ways of testing.

Updated the NetworkAnimatorTests to acquire the state info from NetworkAnimator.SynchronizationStateInfo.

Co-authored-by: Unity Netcode CI <74025435+netcode-ci-service@users.noreply.github.com>

Author: NoelStephensUnity

com.unity.netcode.gameobjects/CHANGELOG.md

@@ -20,11 +20,15 @@ Additional documentation and release notes are available at [Multiplayer Documen
 - Network prefabs are now stored in a ScriptableObject that can be shared between NetworkManagers, and have been exposed for public access. By default, a Default Prefabs List is created that contains all NetworkObject prefabs in the project, and new NetworkManagers will default to using that unless that option is turned off in the Netcode for GameObjects settings. Existing NetworkManagers will maintain their existing lists, which can be migrated to the new format via a button in their inspector. (#2322)
 
 ### Fixed
+- Fixed a UTP test that was failing when you install Unity Transport package 2.0.0 or newer. (#2347)
 - Fixed issue where `NetcodeSettingsProvider` would throw an exception in Unity 2020.3.x versions. (#2345)
 - Fixed server side issue where, depending upon component ordering, some NetworkBehaviour components might not have their OnNetworkDespawn method invoked if the client side disconnected. (#2323)
 - Fixed a case where data corruption could occur when using UnityTransport when reaching a certain level of send throughput. (#2332)
 - Fixed an issue in `UnityTransport` where an exception would be thrown if starting a Relay host/server on WebGL. This exception should only be thrown if using direct connections (where WebGL can't act as a host/server). (#2321)
-- Fixed a UTP test that was failing when you install Unity Transport package 2.0.0 or newer. (#2347)
+- Fixed `NetworkAnimator` issue where it was not checking for `AnimatorStateTtansition.destinationStateMachine` and any possible sub-states defined within it. (#2309)
+- Fixed `NetworkAnimator` issue where the host client was receiving the ClientRpc animation updates when the host was the owner.(#2309)
+- Fixed `NetworkAnimator` issue with using pooled objects and when specific properties are cleaned during despawn and destroy.(#2309)
+- Fixed issue where `NetworkAnimator` was checking for animation changes when the associated `NetworkObject` was not spawned.(#2309)
 
 ## [1.2.0] - 2022-11-21
 

com.unity.netcode.gameobjects/Components/AssemblyInfo.cs

@@ -1,10 +1,15 @@
 using System.Runtime.CompilerServices;
 
 #if UNITY_EDITOR
-[assembly: InternalsVisibleTo("Unity.Netcode.EditorTests")]
 [assembly: InternalsVisibleTo("Unity.Netcode.Editor.CodeGen")]
 [assembly: InternalsVisibleTo("Unity.Netcode.Editor")]
+#endif
+
+#if UNITY_INCLUDE_TESTS
+#if UNITY_EDITOR
+[assembly: InternalsVisibleTo("Unity.Netcode.EditorTests")]
 [assembly: InternalsVisibleTo("TestProject.EditorTests")]
-[assembly: InternalsVisibleTo("TestProject.RuntimeTests")]
 #endif
+[assembly: InternalsVisibleTo("TestProject.RuntimeTests")]
 [assembly: InternalsVisibleTo("Unity.Netcode.RuntimeTests")]
+#endif

com.unity.netcode.gameobjects/Components/NetworkAnimator.cs

@@ -165,14 +165,20 @@ private void DisplayTestIntValueIfChanged()
                 m_TestIntValue = testIntValue;
                 Debug.Log($"[{name}]TestInt value changed to = {m_TestIntValue}");
             }
-            var testFloatValue = m_Animator.GetInteger("TestFloat");
+            var testFloatValue = m_Animator.GetFloat("TestFloat");
             if (m_TestFloatValue != testFloatValue)
             {
                 m_TestFloatValue = testFloatValue;
                 Debug.Log($"[{name}]TestFloat value changed to = {m_TestIntValue}");
             }
         }
 
+        private void BeginAttack(int weaponType)
+        {
+            m_Animator.SetInteger("WeaponType", weaponType);
+            m_NetworkAnimator.SetTrigger("Attack");
+        }
+
         private void LateUpdate()
         {
 
@@ -212,6 +218,17 @@ private void LateUpdate()
                 Debug.Log($"[{name}] TestInt value = {m_TestIntValue}");
                 Debug.Log($"[{name}] TestInt value = {m_TestIntValue}");
             }
+
+            if (Input.GetKeyDown(KeyCode.Alpha1))
+            {
+                BeginAttack(1);
+            }
+
+            if (Input.GetKeyDown(KeyCode.Alpha2))
+            {
+                BeginAttack(2);
+            }
+
         }
     }
 }