chore: Named/Unnamed Message, ServerLogs, and SceneEvents missing mes… (#1316) (#1346)

andrews-unity · kvassall-unity · web-flow · commit 3f0a1cb860ed · 2021-10-22T23:24:55.000Z
* chore: Named/Unnamed Message, ServerLogs, and SceneEvents missing message overhead

* PR Feedback

* PR Feedback

Co-authored-by: Andrew Spiering &lt;andrews@unity3d.com&gt;

Co-authored-by: kvassall-unity &lt;68920108+kvassall-unity@users.noreply.github.com&gt;
diff --git a/com.unity.netcode.gameobjects/Runtime/Messaging/CustomMessageManager.cs b/com.unity.netcode.gameobjects/Runtime/Messaging/CustomMessageManager.cs
@@ -40,7 +40,7 @@ internal void InvokeUnnamedMessage(ulong clientId, FastBufferReader reader)
                     ((UnnamedMessageDelegate)handler).Invoke(clientId, reader);
                 }
             }
-            m_NetworkManager.NetworkMetrics.TrackUnnamedMessageReceived(clientId, reader.Length);
+            m_NetworkManager.NetworkMetrics.TrackUnnamedMessageReceived(clientId, reader.Length + FastBufferWriter.GetWriteSize<MessageHeader>());
         }
 
         /// <summary>
@@ -53,7 +53,6 @@ public void SendUnnamedMessageToAll(FastBufferWriter messageBuffer, NetworkDeliv
             SendUnnamedMessage(m_NetworkManager.ConnectedClientsIds, messageBuffer, networkDelivery);
         }
 
-
         /// <summary>
         /// Sends unnamed message to a list of clients
         /// </summary>
@@ -118,7 +117,7 @@ public void SendUnnamedMessage(ulong clientId, FastBufferWriter messageBuffer, N
 
         internal void InvokeNamedMessage(ulong hash, ulong sender, FastBufferReader reader)
         {
-            var bytesCount = reader.Length;
+            var bytesCount = reader.Length + FastBufferWriter.GetWriteSize<MessageHeader>();
 
             if (m_NetworkManager == null)
             {
diff --git a/com.unity.netcode.gameobjects/Runtime/Messaging/MessagingSystem.cs b/com.unity.netcode.gameobjects/Runtime/Messaging/MessagingSystem.cs
@@ -226,7 +226,7 @@ public void HandleMessage(in MessageHeader header, FastBufferReader reader, ulon
 
             for (var hookIdx = 0; hookIdx < m_Hooks.Count; ++hookIdx)
             {
-                m_Hooks[hookIdx].OnBeforeReceiveMessage(senderId, type, reader.Length);
+                m_Hooks[hookIdx].OnBeforeReceiveMessage(senderId, type, reader.Length + FastBufferWriter.GetWriteSize<MessageHeader>());
             }
             var handler = m_MessageHandlers[header.MessageType];
             using (reader)
@@ -247,7 +247,7 @@ public void HandleMessage(in MessageHeader header, FastBufferReader reader, ulon
             }
             for (var hookIdx = 0; hookIdx < m_Hooks.Count; ++hookIdx)
             {
-                m_Hooks[hookIdx].OnAfterReceiveMessage(senderId, type, reader.Length);
+                m_Hooks[hookIdx].OnAfterReceiveMessage(senderId, type, reader.Length + FastBufferWriter.GetWriteSize<MessageHeader>());
             }
         }
 
@@ -310,8 +310,13 @@ internal unsafe int SendMessage<TMessageType, TClientIdListType>(in TMessageType
             where TMessageType : INetworkMessage
             where TClientIdListType : IReadOnlyList<ulong>
         {
+            if (clientIds.Count == 0)
+            {
+                return 0;
+            }
+
             var maxSize = delivery == NetworkDelivery.ReliableFragmentedSequenced ? FRAGMENTED_MESSAGE_MAX_SIZE : NON_FRAGMENTED_MESSAGE_MAX_SIZE;
-            var tmpSerializer = new FastBufferWriter(NON_FRAGMENTED_MESSAGE_MAX_SIZE - sizeof(MessageHeader), Allocator.Temp, maxSize - sizeof(MessageHeader));
+            var tmpSerializer = new FastBufferWriter(NON_FRAGMENTED_MESSAGE_MAX_SIZE - FastBufferWriter.GetWriteSize<MessageHeader>(), Allocator.Temp, maxSize - FastBufferWriter.GetWriteSize<MessageHeader>());
             using (tmpSerializer)
             {
                 message.Serialize(tmpSerializer);
@@ -342,7 +347,7 @@ internal unsafe int SendMessage<TMessageType, TClientIdListType>(in TMessageType
                         ref var lastQueueItem = ref sendQueueItem.GetUnsafeList()->ElementAt(sendQueueItem.Length - 1);
                         if (lastQueueItem.NetworkDelivery != delivery ||
                             lastQueueItem.Writer.MaxCapacity - lastQueueItem.Writer.Position
-                            < tmpSerializer.Length + sizeof(MessageHeader))
+                            < tmpSerializer.Length + FastBufferWriter.GetWriteSize<MessageHeader>())
                         {
                             sendQueueItem.Add(new SendQueueItem(delivery, NON_FRAGMENTED_MESSAGE_MAX_SIZE, Allocator.TempJob,
                                 maxSize));
@@ -351,7 +356,7 @@ internal unsafe int SendMessage<TMessageType, TClientIdListType>(in TMessageType
                     }
 
                     ref var writeQueueItem = ref sendQueueItem.GetUnsafeList()->ElementAt(sendQueueItem.Length - 1);
-                    writeQueueItem.Writer.TryBeginWrite(sizeof(MessageHeader) + tmpSerializer.Length);
+                    writeQueueItem.Writer.TryBeginWrite(tmpSerializer.Length + FastBufferWriter.GetWriteSize<MessageHeader>());
                     var header = new MessageHeader
                     {
                         MessageSize = (ushort)tmpSerializer.Length,
@@ -363,11 +368,11 @@ internal unsafe int SendMessage<TMessageType, TClientIdListType>(in TMessageType
                     writeQueueItem.BatchHeader.BatchSize++;
                     for (var hookIdx = 0; hookIdx < m_Hooks.Count; ++hookIdx)
                     {
-                        m_Hooks[hookIdx].OnAfterSendMessage(clientId, typeof(TMessageType), delivery, tmpSerializer.Length + sizeof(MessageHeader));
+                        m_Hooks[hookIdx].OnAfterSendMessage(clientId, typeof(TMessageType), delivery, tmpSerializer.Length + FastBufferWriter.GetWriteSize<MessageHeader>());
                     }
                 }
 
-                return tmpSerializer.Length;
+                return tmpSerializer.Length + FastBufferWriter.GetWriteSize<MessageHeader>();
             }
         }
 
diff --git a/com.unity.netcode.gameobjects/Tests/Runtime/Metrics/MessagingMetricsTests.cs b/com.unity.netcode.gameobjects/Tests/Runtime/Metrics/MessagingMetricsTests.cs
@@ -14,9 +14,9 @@ namespace Unity.Netcode.RuntimeTests.Metrics
 {
     public class MessagingMetricsTests : DualClientMetricTestBase
     {
-        const uint MessageNameHashSize = 8;
-
-        const uint MessageOverhead = MessageNameHashSize;
+        private const uint k_MessageNameHashSize = 8;
+        private static readonly int k_NamedMessageOverhead = (int)k_MessageNameHashSize + FastBufferWriter.GetWriteSize<MessageHeader>();
+        private static readonly int k_UnnamedMessageOverhead = FastBufferWriter.GetWriteSize<MessageHeader>();
 
         protected override int NbClients => 2;
 
@@ -111,7 +111,7 @@ public IEnumerator TrackNamedMessageSentMetric()
             var namedMessageSent = namedMessageSentMetricValues.First();
             Assert.AreEqual(messageName.ToString(), namedMessageSent.Name);
             Assert.AreEqual(FirstClient.LocalClientId, namedMessageSent.Connection.Id);
-            Assert.AreEqual(FastBufferWriter.GetWriteSize(messageName) + MessageOverhead, namedMessageSent.BytesCount);
+            Assert.AreEqual(FastBufferWriter.GetWriteSize(messageName) + k_NamedMessageOverhead, namedMessageSent.BytesCount);
         }
 
         [UnityTest]
@@ -132,7 +132,7 @@ public IEnumerator TrackNamedMessageSentMetricToMultipleClients()
             var namedMessageSentMetricValues = waitForMetricValues.AssertMetricValuesHaveBeenFound();
             Assert.AreEqual(2, namedMessageSentMetricValues.Count);
             Assert.That(namedMessageSentMetricValues.Select(x => x.Name), Has.All.EqualTo(messageName.ToString()));
-            Assert.That(namedMessageSentMetricValues.Select(x => x.BytesCount), Has.All.EqualTo(FastBufferWriter.GetWriteSize(messageName) + MessageOverhead));
+            Assert.That(namedMessageSentMetricValues.Select(x => x.BytesCount), Has.All.EqualTo(FastBufferWriter.GetWriteSize(messageName) + k_NamedMessageOverhead));
         }
 
         [UnityTest]
@@ -181,7 +181,7 @@ public IEnumerator TrackNamedMessageReceivedMetric()
             var namedMessageReceived = namedMessageReceivedValues.First();
             Assert.AreEqual(messageName.ToString(), namedMessageReceived.Name);
             Assert.AreEqual(Server.LocalClientId, namedMessageReceived.Connection.Id);
-            Assert.AreEqual(FastBufferWriter.GetWriteSize(messageName) + MessageOverhead, namedMessageReceived.BytesCount);
+            Assert.AreEqual(FastBufferWriter.GetWriteSize(messageName) + k_NamedMessageOverhead, namedMessageReceived.BytesCount);
         }
 
         [UnityTest]
@@ -205,7 +205,7 @@ public IEnumerator TrackUnnamedMessageSentMetric()
 
             var unnamedMessageSent = unnamedMessageSentMetricValues.First();
             Assert.AreEqual(FirstClient.LocalClientId, unnamedMessageSent.Connection.Id);
-            Assert.AreEqual(FastBufferWriter.GetWriteSize(message), unnamedMessageSent.BytesCount);
+            Assert.AreEqual(FastBufferWriter.GetWriteSize(message) + k_UnnamedMessageOverhead, unnamedMessageSent.BytesCount);
         }
 
         [UnityTest]
@@ -225,7 +225,7 @@ public IEnumerator TrackUnnamedMessageSentMetricToMultipleClients()
 
             var unnamedMessageSentMetricValues = waitForMetricValues.AssertMetricValuesHaveBeenFound();
             Assert.AreEqual(2, unnamedMessageSentMetricValues.Count);
-            Assert.That(unnamedMessageSentMetricValues.Select(x => x.BytesCount), Has.All.EqualTo(FastBufferWriter.GetWriteSize(message)));
+            Assert.That(unnamedMessageSentMetricValues.Select(x => x.BytesCount), Has.All.EqualTo(FastBufferWriter.GetWriteSize(message) + k_UnnamedMessageOverhead));
 
             var clientIds = unnamedMessageSentMetricValues.Select(x => x.Connection.Id).ToList();
             Assert.Contains(FirstClient.LocalClientId, clientIds);
@@ -268,7 +268,7 @@ public IEnumerator TrackUnnamedMessageReceivedMetric()
 
             var unnamedMessageReceived = unnamedMessageReceivedValues.First();
             Assert.AreEqual(Server.LocalClientId, unnamedMessageReceived.Connection.Id);
-            Assert.AreEqual(FastBufferWriter.GetWriteSize(message), unnamedMessageReceived.BytesCount);
+            Assert.AreEqual(FastBufferWriter.GetWriteSize(message) + k_UnnamedMessageOverhead, unnamedMessageReceived.BytesCount);
         }
     }
 }
diff --git a/com.unity.netcode.gameobjects/Tests/Runtime/Metrics/OwnershipChangeMetricsTests.cs b/com.unity.netcode.gameobjects/Tests/Runtime/Metrics/OwnershipChangeMetricsTests.cs
@@ -58,7 +58,7 @@ public IEnumerator TrackOwnershipChangeSentMetric()
             var ownershipChangeSent = metricValues.First();
             Assert.AreEqual(networkObject.NetworkObjectId, ownershipChangeSent.NetworkId.NetworkId);
             Assert.AreEqual(Server.LocalClientId, ownershipChangeSent.Connection.Id);
-            Assert.AreEqual(FastBufferWriter.GetWriteSize<ChangeOwnershipMessage>(), ownershipChangeSent.BytesCount);
+            Assert.AreEqual(FastBufferWriter.GetWriteSize<ChangeOwnershipMessage>() + FastBufferWriter.GetWriteSize<MessageHeader>(), ownershipChangeSent.BytesCount);
         }
 
         [UnityTest]
diff --git a/com.unity.netcode.gameobjects/Tests/Runtime/Metrics/ServerLogsMetricTests.cs b/com.unity.netcode.gameobjects/Tests/Runtime/Metrics/ServerLogsMetricTests.cs
@@ -11,6 +11,9 @@ namespace Unity.Netcode.RuntimeTests.Metrics
 {
     internal class ServerLogsMetricTests : SingleClientMetricTestBase
     {
+        private static readonly int k_ServerLogSentMessageOverhead = 2 + FastBufferWriter.GetWriteSize<MessageHeader>();
+        private static readonly int k_ServerLogReceivedMessageOverhead = 2;
+
         [UnityTest]
         public IEnumerator TrackServerLogSentMetric()
         {
@@ -27,7 +30,7 @@ public IEnumerator TrackServerLogSentMetric()
             var sentMetric = sentMetrics.First();
             Assert.AreEqual(Server.LocalClientId, sentMetric.Connection.Id);
             Assert.AreEqual((uint)NetworkLog.LogType.Warning, (uint)sentMetric.LogLevel);
-            Assert.AreEqual(message.Length + 2, sentMetric.BytesCount);
+            Assert.AreEqual(message.Length + k_ServerLogSentMessageOverhead, sentMetric.BytesCount);
         }
 
         [UnityTest]
@@ -46,7 +49,7 @@ public IEnumerator TrackServerLogReceivedMetric()
             var receivedMetric = receivedMetrics.First();
             Assert.AreEqual(Client.LocalClientId, receivedMetric.Connection.Id);
             Assert.AreEqual((uint)NetworkLog.LogType.Warning, (uint)receivedMetric.LogLevel);
-            Assert.AreEqual(message.Length + 2, receivedMetric.BytesCount);
+            Assert.AreEqual(message.Length + k_ServerLogReceivedMessageOverhead, receivedMetric.BytesCount);
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ internal void InvokeUnnamedMessage(ulong clientId, FastBufferReader reader)`
`40`	`40`	`((UnnamedMessageDelegate)handler).Invoke(clientId, reader);`
`41`	`41`	`}`
`42`	`42`	`}`
`43`		`- m_NetworkManager.NetworkMetrics.TrackUnnamedMessageReceived(clientId, reader.Length);`
	`43`	`+ m_NetworkManager.NetworkMetrics.TrackUnnamedMessageReceived(clientId, reader.Length + FastBufferWriter.GetWriteSize<MessageHeader>());`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`/// <summary>`
`@@ -53,7 +53,6 @@ public void SendUnnamedMessageToAll(FastBufferWriter messageBuffer, NetworkDeliv`
`53`	`53`	`SendUnnamedMessage(m_NetworkManager.ConnectedClientsIds, messageBuffer, networkDelivery);`
`54`	`54`	`}`
`55`	`55`
`56`		`-`
`57`	`56`	`/// <summary>`
`58`	`57`	`/// Sends unnamed message to a list of clients`
`59`	`58`	`/// </summary>`
`@@ -118,7 +117,7 @@ public void SendUnnamedMessage(ulong clientId, FastBufferWriter messageBuffer, N`
`118`	`117`
`119`	`118`	`internal void InvokeNamedMessage(ulong hash, ulong sender, FastBufferReader reader)`
`120`	`119`	`{`
`121`		`- var bytesCount = reader.Length;`
	`120`	`+ var bytesCount = reader.Length + FastBufferWriter.GetWriteSize<MessageHeader>();`
`122`	`121`
`123`	`122`	`if (m_NetworkManager == null)`
`124`	`123`	`{`
Original file line number	Diff line number	Diff line change
`@@ -226,7 +226,7 @@ public void HandleMessage(in MessageHeader header, FastBufferReader reader, ulon`
`226`	`226`
`227`	`227`	`for (var hookIdx = 0; hookIdx < m_Hooks.Count; ++hookIdx)`
`228`	`228`	`{`
`229`		`- m_Hooks[hookIdx].OnBeforeReceiveMessage(senderId, type, reader.Length);`
	`229`	`+ m_Hooks[hookIdx].OnBeforeReceiveMessage(senderId, type, reader.Length + FastBufferWriter.GetWriteSize<MessageHeader>());`
`230`	`230`	`}`
`231`	`231`	`var handler = m_MessageHandlers[header.MessageType];`
`232`	`232`	`using (reader)`
`@@ -247,7 +247,7 @@ public void HandleMessage(in MessageHeader header, FastBufferReader reader, ulon`
`247`	`247`	`}`
`248`	`248`	`for (var hookIdx = 0; hookIdx < m_Hooks.Count; ++hookIdx)`
`249`	`249`	`{`
`250`		`- m_Hooks[hookIdx].OnAfterReceiveMessage(senderId, type, reader.Length);`
	`250`	`+ m_Hooks[hookIdx].OnAfterReceiveMessage(senderId, type, reader.Length + FastBufferWriter.GetWriteSize<MessageHeader>());`
`251`	`251`	`}`
`252`	`252`	`}`
`253`	`253`
`@@ -310,8 +310,13 @@ internal unsafe int SendMessage<TMessageType, TClientIdListType>(in TMessageType`
`310`	`310`	`where TMessageType : INetworkMessage`
`311`	`311`	`where TClientIdListType : IReadOnlyList<ulong>`
`312`	`312`	`{`
	`313`	`+ if (clientIds.Count == 0)`
	`314`	`+ {`
	`315`	`+ return 0;`
	`316`	`+ }`
	`317`	`+`
`313`	`318`	`var maxSize = delivery == NetworkDelivery.ReliableFragmentedSequenced ? FRAGMENTED_MESSAGE_MAX_SIZE : NON_FRAGMENTED_MESSAGE_MAX_SIZE;`
`314`		`- var tmpSerializer = new FastBufferWriter(NON_FRAGMENTED_MESSAGE_MAX_SIZE - sizeof(MessageHeader), Allocator.Temp, maxSize - sizeof(MessageHeader));`
	`319`	`+ var tmpSerializer = new FastBufferWriter(NON_FRAGMENTED_MESSAGE_MAX_SIZE - FastBufferWriter.GetWriteSize<MessageHeader>(), Allocator.Temp, maxSize - FastBufferWriter.GetWriteSize<MessageHeader>());`
`315`	`320`	`using (tmpSerializer)`
`316`	`321`	`{`
`317`	`322`	`message.Serialize(tmpSerializer);`
`@@ -342,7 +347,7 @@ internal unsafe int SendMessage<TMessageType, TClientIdListType>(in TMessageType`
`342`	`347`	`ref var lastQueueItem = ref sendQueueItem.GetUnsafeList()->ElementAt(sendQueueItem.Length - 1);`
`343`	`348`	`if (lastQueueItem.NetworkDelivery != delivery \|\|`
`344`	`349`	`lastQueueItem.Writer.MaxCapacity - lastQueueItem.Writer.Position`
`345`		`- < tmpSerializer.Length + sizeof(MessageHeader))`
	`350`	`+ < tmpSerializer.Length + FastBufferWriter.GetWriteSize<MessageHeader>())`
`346`	`351`	`{`
`347`	`352`	`sendQueueItem.Add(new SendQueueItem(delivery, NON_FRAGMENTED_MESSAGE_MAX_SIZE, Allocator.TempJob,`
`348`	`353`	`maxSize));`
`@@ -351,7 +356,7 @@ internal unsafe int SendMessage<TMessageType, TClientIdListType>(in TMessageType`
`351`	`356`	`}`
`352`	`357`
`353`	`358`	`ref var writeQueueItem = ref sendQueueItem.GetUnsafeList()->ElementAt(sendQueueItem.Length - 1);`
`354`		`- writeQueueItem.Writer.TryBeginWrite(sizeof(MessageHeader) + tmpSerializer.Length);`
	`359`	`+ writeQueueItem.Writer.TryBeginWrite(tmpSerializer.Length + FastBufferWriter.GetWriteSize<MessageHeader>());`
`355`	`360`	`var header = new MessageHeader`
`356`	`361`	`{`
`357`	`362`	`MessageSize = (ushort)tmpSerializer.Length,`
`@@ -363,11 +368,11 @@ internal unsafe int SendMessage<TMessageType, TClientIdListType>(in TMessageType`
`363`	`368`	`writeQueueItem.BatchHeader.BatchSize++;`
`364`	`369`	`for (var hookIdx = 0; hookIdx < m_Hooks.Count; ++hookIdx)`
`365`	`370`	`{`
`366`		`- m_Hooks[hookIdx].OnAfterSendMessage(clientId, typeof(TMessageType), delivery, tmpSerializer.Length + sizeof(MessageHeader));`
	`371`	`+ m_Hooks[hookIdx].OnAfterSendMessage(clientId, typeof(TMessageType), delivery, tmpSerializer.Length + FastBufferWriter.GetWriteSize<MessageHeader>());`
`367`	`372`	`}`
`368`	`373`	`}`
`369`	`374`
`370`		`- return tmpSerializer.Length;`
	`375`	`+ return tmpSerializer.Length + FastBufferWriter.GetWriteSize<MessageHeader>();`
`371`	`376`	`}`
`372`	`377`	`}`
`373`	`378`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ public IEnumerator TrackOwnershipChangeSentMetric()`
`58`	`58`	`var ownershipChangeSent = metricValues.First();`
`59`	`59`	`Assert.AreEqual(networkObject.NetworkObjectId, ownershipChangeSent.NetworkId.NetworkId);`
`60`	`60`	`Assert.AreEqual(Server.LocalClientId, ownershipChangeSent.Connection.Id);`
`61`		`- Assert.AreEqual(FastBufferWriter.GetWriteSize<ChangeOwnershipMessage>(), ownershipChangeSent.BytesCount);`
	`61`	`+ Assert.AreEqual(FastBufferWriter.GetWriteSize<ChangeOwnershipMessage>() + FastBufferWriter.GetWriteSize<MessageHeader>(), ownershipChangeSent.BytesCount);`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`[UnityTest]`
Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,9 @@ namespace Unity.Netcode.RuntimeTests.Metrics`
`11`	`11`	`{`
`12`	`12`	`internal class ServerLogsMetricTests : SingleClientMetricTestBase`
`13`	`13`	`{`
	`14`	`+ private static readonly int k_ServerLogSentMessageOverhead = 2 + FastBufferWriter.GetWriteSize<MessageHeader>();`
	`15`	`+ private static readonly int k_ServerLogReceivedMessageOverhead = 2;`
	`16`	`+`
`14`	`17`	`[UnityTest]`
`15`	`18`	`public IEnumerator TrackServerLogSentMetric()`
`16`	`19`	`{`
`@@ -27,7 +30,7 @@ public IEnumerator TrackServerLogSentMetric()`
`27`	`30`	`var sentMetric = sentMetrics.First();`
`28`	`31`	`Assert.AreEqual(Server.LocalClientId, sentMetric.Connection.Id);`
`29`	`32`	`Assert.AreEqual((uint)NetworkLog.LogType.Warning, (uint)sentMetric.LogLevel);`
`30`		`- Assert.AreEqual(message.Length + 2, sentMetric.BytesCount);`
	`33`	`+ Assert.AreEqual(message.Length + k_ServerLogSentMessageOverhead, sentMetric.BytesCount);`
`31`	`34`	`}`
`32`	`35`
`33`	`36`	`[UnityTest]`
`@@ -46,7 +49,7 @@ public IEnumerator TrackServerLogReceivedMetric()`
`46`	`49`	`var receivedMetric = receivedMetrics.First();`
`47`	`50`	`Assert.AreEqual(Client.LocalClientId, receivedMetric.Connection.Id);`
`48`	`51`	`Assert.AreEqual((uint)NetworkLog.LogType.Warning, (uint)receivedMetric.LogLevel);`
`49`		`- Assert.AreEqual(message.Length + 2, receivedMetric.BytesCount);`
	`52`	`+ Assert.AreEqual(message.Length + k_ServerLogReceivedMessageOverhead, receivedMetric.BytesCount);`
`50`	`53`	`}`
`51`	`54`	`}`
`52`	`55`	`}`