CMCL-866 - Confiner2D precision issues #530
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… flight control) - 2022.1, 2022.2, trunk
gaborkb
changed the title
Codecov Report
@@ Coverage Diff @@
## release-prep/2.9.0 #530 +/- ##
======================================================
+ Coverage 24.01% 24.03% +0.01%
======================================================
Files 126 126
Lines 18659 18663 +4
======================================================
+ Hits 4481 4485 +4
Misses 14178 14178
|
glabute
requested changes
Aug 10, 2022
There was a problem hiding this comment.
Camera still moves (a little) in the sample scene, even at max quality.
I'm not convinced that this quality business is a good strategy for handling such edge cases. 0.000005f is an insanely small step size. Maybe we can have a discussion about how to solve this better.
| const float k_MinStepSize = 0.005f; | ||
|
|
||
| float m_MinStepSize = k_MinStepSize; | ||
| const float k_MinStepSize = 0.005f, k_MaxStepSize = 0.000005f; |
| const float k_IntToFloatScaler = 1.0f / k_FloatToIntScaler; | ||
| const float k_MinStepSize = 0.005f; | ||
|
|
||
| float m_MinStepSize = k_MinStepSize; |
There was a problem hiding this comment.
should this be called m_StepSize or something like that? It's a bit confusing between m_MinStepSize and k_MinStepSize.
|
|
||
| m_confinerOven = new ConfinerOven(m_OriginalPath, aspectRatio, maxWindowSize); | ||
|
|
||
| quality = (quality - k_QualityMin) / k_QualityMax; // normalize quality to [0-1] |
There was a problem hiding this comment.
Normalization is not guaranteed, because caller can pass anything for quality
|
No longer relevant. See clipper2 in CM3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
https://jira.unity3d.com/browse/CMCL-866 (has repro project)
(This fix will need to be added to 3 and 2.8).
The initial fix for this issue was not precise enough. So now we allow equality for the special case.
Change at
line 264incom.unity.cinemachine/Runtime/Core/ConfinerOven.cs.Added new m_Quality field.
I played around with the min step size, and it can be used to improve the quality of the confiner in some of these edge cases. I did not find a big performance impact either. I created a prototype quality control, but maybe we should expose the quality parameter as a scripting API only.
Testing status
Documentation status
Technical risk
Comments to reviewers
Package version