Skip to content

CMCL-906: 3rdPersonFollow does not warn user when no Follow Target #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2022
Merged

CMCL-906: 3rdPersonFollow does not warn user when no Follow Target #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8aaa422
3rdPersonFollow
gaborkb May 6, 2022
f8453af
Changelog
gaborkb May 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.cinemachine/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## UNRELEASED
- Bugfix: Confiner2D confines to midpoint when camera window is bigger than the axis aligned bounding box of the input confiner.
- Bugfix: 3rdPersonFollow shows a warning message when no follow target is assigned like the rest of the body components.


## [2.9.0-pre.7] - 2022-03-29
Expand Down
13 changes: 13 additions & 0 deletions com.unity.cinemachine/Editor/Editors/Cinemachine3rdPersonFollowEditor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,19 @@ static void Draw3rdPersonGizmos(Cinemachine3rdPersonFollow target, GizmoType sel
Gizmos.color = originalGizmoColour;
}
}

public override void OnInspectorGUI()
{
BeginInspector();
bool needWarning = false;
for (int i = 0; !needWarning && i < targets.Length; ++i)
needWarning = (targets[i] as Cinemachine3rdPersonFollow).FollowTarget == null;
if (needWarning)
EditorGUILayout.HelpBox(
"3rd Person Follow requires a Follow Target. Change Body to Do Nothing if you don't want a Follow target.",
MessageType.Warning);
DrawRemainingPropertiesInInspector();
}

#if UNITY_2021_2_OR_NEWER
protected virtual void OnEnable()
Expand Down