CMCL-519: improve samples #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent future conflict errors. Cleanup
…ible name conflict with other skybox materials. Cleaned up scene help message.
AntoineCharton
approved these changes
Jan 20, 2022
glabute
approved these changes
Jan 23, 2022
gaborkb
added a commit
that referenced
this pull request
Jul 21, 2022
* CMCL-739: Adjust Handles Docs (#379) * Adjust Handles Docs for 2022 * Update handles.md addressed comment. * CMCL-722: fix promotion job, bump version to 2.9.0-pre.6 (#382) * bumped package version to pre.6 * use UPMCI_PROMOTION variable on tests and use promotion-audit in addition to vetting-tests * refactored yamato jobs * removed 2019.4 from isolation tests - triggers package validation error due to types disappearing due to missing dependencies * CMCL-738: Tooltips are now correct (#377) * Tooltips are now correct * Changelog * CMCL-519: improve samples (#384) * Fix timeline warnings * 3rdPersonWithAimMode warnings fix * All example scripts are in namespace Cinemachine.Examples now to prevent future conflict errors. Cleanup * Anywhere door does not use skybox (instead solid color) to avoid possible name conflict with other skybox materials. Cleaned up scene help message. * fixed broken 3rdPersonWithAimMode (aim mode priority was wrong) * Changelog Co-authored-by: Greg Labute <gregoryl@unity3d.com> * CMCL-757: Standalone profiler freezes (#385) * Fix Standalone profiler freeze * Changelog * Added guard for 2020.3+ * CMCL-771: Cinemachine 2.8.4 produce compiler errors if Input System package is installed. (#392) * local static functions are not supported in C#8 or editors earlier than 2020. * Changelog * No need to use static. If I pass in the parameters I use, no variables are going to be captured (which would also cause gc) - this way no need to add ugly guards either * Removed accidentally added new lines * CMCL-768: PP memleak (#388) Co-authored-by: Krisztian G. Birkas <57672095+gaborkb@users.noreply.github.com> * CMCL-240: Documentation for Simplified Impulse system (#391) * Impulse doc updates Impulse doc updates * spelling correction * CMCL-779: ImpulseDefinition property not displayed correctly in the editor. (#394) * check field for null * changelog * typo * CMCL-767: added codecov.io upload (#387) * moved coverage to separate package-coverage.yaml file * added codecov.io upload * CMCL-783: Timeline guard (#398) * Timeline guards added * Changelog * Fix part 2. Legacy type was not displayed when part of an array (#397) * CMCL-822: SaveDuringPlay for ILists (#407) * WIP * Works for List * TODO * Meh, this is just bad. We should use serialize/deserialze to save changes * Works for Ilist, test for list of nulls and list of objects * Fix for list of objects. Create new items for each entry, instead of one entry and many references :) * changelog * Comments for code * optimize remove operation * Removed unused kVersionString (#411) * InputProvider correctly tracks enabled state of actions (#418) * POV orientation was incorrect with world up override set (#420) * Some Handles doc updates and general language improvements (#422) * CMCL-400: Add test for hdrp and urp (#408) * Add test for hdrp and urp - Add test projects for URP, HDRP and standelone - Add test package - Update Yamato file to support the new layout * Fix pack not finding manifest * Fix version null on tests * Fix path issue * Fix tests not finding editor version * Pack the tests package * Fix typo in pack command * Removed test package * Remove test package from project manifest * Fixed invalid arguments * Fix project tests arguments * Request a GPU machine for tests * Fix path issue with package in project manifests * Remove GPU requests * Readded package test * add project pack * Fix path issue * Fix dependancy * Revert changes * Fix project test invalid command * Fix corevage comman * Fix coverage not executing * Fix package test error * Remove package test * Revert project test removed * Remove unecessary test * Add standelone tests * Fix typo in projects path * Fix trigger * Add test projects list * Add project name in the test name * Add path to test project * Add test arguments * Downgrade HDRP version * Remove unity 2019 from tested editors * Add hdrp projects * Update meta file * Enable hdrp testing * Simplify tests names * Add windows tests to ci configuration * Update promotion, publish and test coverage * Fix incorect hdrp version * Update HDRP project to make it compatible with 2020 * Revert "Update HDRP project to make it compatible with 2020" This reverts commit e4adce7. Commit fixed HDRP issues on 2020 but broke the other versions * Ignore blending test on HDRP unity 2020 * Fix naming typos and unecessary tests Fix naming issues from Standelone to Standalone Remove unecessary test for vetting and promotion tests * Test promotion tests * Remove srps project from isolation tests * Add pacakge args to the config * Fix test running on projects instead of package - Add project test - Edit package test to avoid project test * Fix pacakge test running multiple time * add pack to package pack * Add package artifacts * Revert pacakage tests * Add project pack job * Add project pack dependancy on projects tests * Add project pack * Fix coverage job dependancy * Remove dependancy of pack for package CI Add package test * Fix missing dependancy * Fix duplicates job names * Remove isolation tests from config * Reverted changes in packages and added project * Fix project pack * Fix package test path * Add multiple editor and versions * Fix path * Fix test projects typo * Remove unecessary 2019 tests * Remove integration test from package tests * Add projects test for windows and mac * Revert package ci * Add windows to package ci * Add macos to package ci * Remove mac os tests * Clean up project job names * Run macos tests on ci * Add 2019.4 to pacakge tests * Remove unecessary dependencies * Remove unecessary for loops * Fix 2019 standalone project issue * Remove 2019.4 for projects tests Remove 2019.4 tests for projects Add integration tests for 2019.4 * Test promotion tests * Run on windows to test promotion tests * Fix isolation test running on projects * Fix typo in project test * Fix project test arguments * Fix type to array * Fix type command issue * Update URP project to 2019.4 * Remove promotion tests * Bump version and changelog * Added date field to make tests pass * Add 2019.4 project and fix images * Add testable to manifest * add auto-enable option to input handler (#424) * Added public refresh API (#383) * CMCL-876: Confiner2D confines to midpoint when camera window is bigger than the axis aligned bounding box of the input confiner (#426) * Midpoint collapse * Respect max window size parameter. TODO: added point shrink * Commented out not needed parts. Why is there a difference between slight aspect windoss. line vs fat rectangle * Todod * TODOS: * Works in simple case. Need to test more and cleanup * user set max window size respected * Ignore userset when oversize off * Timeout is back. Cleanup: localized functions, naming, removed redundancies, vars * Special case was never called, because frustumheight was fixed before * When above theoritical max, then we shrank to a point. From this point, the confiner area is completely inside the camera window. * cleanup * cleanup * commnet * changelog * Max because we care about windows that contain the axis aligned confiner bounding box * Frustumheight cleanup * Need to compute theoritical max always * comment * better readability * No local static functions because that might fail in 2019, depending on c# version * Local parameter hid outside parameter * Updated asmdef with new 2D URP assembly (#432) * Update com.unity.cinemachine.asmdef * removed extra change added from editor * CMCL-891: Fix null output camera on first frame (#439) * Fix output camera being null on first frame * Need to update outputCamera when target changes * Unused usings removed * CMCL-906: 3rdPersonFollow does not warn user when no Follow Target (#444) * 3rdPersonFollow * Changelog * CMCL-926: fadeout sample bug fix (#447) * CMCL-711: These tests fail on yamato, we don't know why. (#371) * Soothing bug fixed * Added tests for collider * Test cleanup + fix * Tests work deterministically * CMCL-514: Hovering and knowing which handles are picked/dragged (#425) * 3rdPersonFollow * FOV * TrackedObjectOffset + simplified 3rdPerson position handle * TransposerFollowOffset * Unwanted import * CMCL-923: Freelook jitter after enable (#448) * Freelook jitter cause found * Orbital Transposer initial heading * Update CinemachineFreeLook.cs * better fix * Changelog Co-authored-by: Greg Labute <gregoryl@unity3d.com> * CMCL-982: spurious z rotations during spherical blend (#462) * CMCL-982: spurious z rotations during spherical blend * fix failing test compilation * CMCL-976: FT and Composer rounding error (#458) * Rounding error fix for FT and C * Changelog * Rounding needs to be done at the Bias level, because center.value and screenX and Y are related * No need to set bias. Do we need to set it to zero even? * remove bias epsilon check Co-authored-by: Greg Labute <gregoryl@unity3d.com> * CMCL-826: Paste VirtualCamera component onto prefab works for pipeline subcomponents (#415) * Paste VirtualCamera component onto prefab works for subcomponents * Update CinemachineVirtualCamera.cs * Paste FreeLook onto prefab also pastes subcomponents Co-authored-by: Krisztian G. Birkas <gaborkb@unity3d.com> * Changelog * CMCL-1005: POV should be relative to its parent (#469) * rotation fix * Changelog cleanup * CMCL-1017: Blending back and forth bugfix (#474) * WIP * WIP * Math is correct now * WIP: cleanup * cleanup done * Changelog * CleanuP * No need to count, bool is enough. Added comments to clarify * simplify, handle only the well-defined cases * fix for asymmetric back and forth blend times * cosmetic Co-authored-by: Greg Labute <gregoryl@unity3d.com> * Blend tests with conditional cmv3 * cleanup * Changelog fixed * Folder structure revert * metas * Release date updated * New folder structure * Add test projects * Fix tests * Update com.unity.cinemachine/CHANGELOG.md Co-authored-by: JWalker0007 <88449056+JWalker0007@users.noreply.github.com> * Update com.unity.cinemachine/CHANGELOG.md Co-authored-by: JWalker0007 <88449056+JWalker0007@users.noreply.github.com> * Update com.unity.cinemachine/CHANGELOG.md Co-authored-by: JWalker0007 <88449056+JWalker0007@users.noreply.github.com> * Update com.unity.cinemachine/CHANGELOG.md Co-authored-by: JWalker0007 <88449056+JWalker0007@users.noreply.github.com> * Update com.unity.cinemachine/CHANGELOG.md Co-authored-by: JWalker0007 <88449056+JWalker0007@users.noreply.github.com> * Update com.unity.cinemachine/CHANGELOG.md Co-authored-by: JWalker0007 <88449056+JWalker0007@users.noreply.github.com> * Update com.unity.cinemachine/CHANGELOG.md Co-authored-by: JWalker0007 <88449056+JWalker0007@users.noreply.github.com> * Update com.unity.cinemachine/CHANGELOG.md Co-authored-by: JWalker0007 <88449056+JWalker0007@users.noreply.github.com> * Update com.unity.cinemachine/CHANGELOG.md Co-authored-by: JWalker0007 <88449056+JWalker0007@users.noreply.github.com> * Update com.unity.cinemachine/CHANGELOG.md Co-authored-by: JWalker0007 <88449056+JWalker0007@users.noreply.github.com> * Update com.unity.cinemachine/CHANGELOG.md Co-authored-by: JWalker0007 <88449056+JWalker0007@users.noreply.github.com> * Update com.unity.cinemachine/CHANGELOG.md Co-authored-by: JWalker0007 <88449056+JWalker0007@users.noreply.github.com> * Update com.unity.cinemachine/CHANGELOG.md Co-authored-by: JWalker0007 <88449056+JWalker0007@users.noreply.github.com> * Update com.unity.cinemachine/CHANGELOG.md Co-authored-by: JWalker0007 <88449056+JWalker0007@users.noreply.github.com> * Update com.unity.cinemachine/CHANGELOG.md Co-authored-by: JWalker0007 <88449056+JWalker0007@users.noreply.github.com> * Bugfix: AxisState.Recentering.RecenterNow() did not work reliably. * Backport for CMCL-1003 - aspect ratio changes affects source control (#492) * Reduce amount of redundant calls to RepaintAllViews (#487) Quick fix for laggy editor described here: https://github.com/Unity-Technologies/com.unity.cinemachine/issues/486 * Changelog for redundant all view calls Co-authored-by: JWalker0007 <88449056+JWalker0007@users.noreply.github.com> Co-authored-by: Mark Visser <markv@unity3d.com> Co-authored-by: Greg Labute <gregoryl@unity3d.com> Co-authored-by: Antoine Charton <antoine.charton@gmail.com> Co-authored-by: Chris Chu <47998819+unity-cchu@users.noreply.github.com> Co-authored-by: krisrok <3404365+krisrok@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fixed issues marked with green:
https://jira.unity3d.com/browse/CMCL-519
Not fixed:
Testing status
Documentation status
Technical risk
Comments to reviewers
Package version