CMCL-710: 3rd person gimbal lock fix #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborkb
approved these changes
Dec 9, 2021
mjmvisser
pushed a commit
that referenced
this pull request
Dec 9, 2021
* eliminate 3rdpersonFollow console spam when looking up or down * revert a too-aggressive change * too aggressive again
mjmvisser
pushed a commit
that referenced
this pull request
Dec 10, 2021
* eliminate 3rdpersonFollow console spam when looking up or down * revert a too-aggressive change * too aggressive again
mjmvisser
pushed a commit
that referenced
this pull request
Dec 17, 2021
* CMCL-667: Show calculated confiner for not live vcams. (#365) * Don't check for isLive * minor doc * CMCL-661: remove illegal destructor (#364) * remove illegal destructor * Update VcamStageEditor.cs * fix exception on undo * CMCL-686: targets forget that they are groups (#366) * add domain reload callback to invalidate target cache * release notes * Fix 2019.4 compile error * Update CHANGELOG.md * CMCL-648: backport (#372) * Input is realtime - backport * Removed collections include * CMCL-706: Fix for InputProvider causes tiny GC alloc every frame (#369) * bumped package version to 2.8.4 * CMCL-710: 3rd person gimbal lock fix (#370) * eliminate 3rdpersonFollow console spam when looking up or down * revert a too-aggressive change * too aggressive again * Update CHANGELOG.md * Fixed missing changelog entry. * Removed mention of handles from changelog * Added missing changelog for CMCL-666. Co-authored-by: Krisztian G. Birkas <57672095+gaborkb@users.noreply.github.com> Co-authored-by: Gregory Labute <gregoryl@unity3d.com>
gaborkb
added a commit
that referenced
this pull request
Feb 16, 2022
* CMCL-667: Show calculated confiner for not live vcams. (#365) * Don't check for isLive * minor doc * CMCL-661: remove illegal destructor (#364) * remove illegal destructor * Update VcamStageEditor.cs * fix exception on undo * CMCL-686: targets forget that they are groups (#366) * add domain reload callback to invalidate target cache * release notes * Fix 2019.4 compile error * Update CHANGELOG.md * CMCL-648: backport (#372) * Input is realtime - backport * Removed collections include * CMCL-706: Fix for InputProvider causes tiny GC alloc every frame (#369) * bumped package version to 2.8.4 * CMCL-710: 3rd person gimbal lock fix (#370) * eliminate 3rdpersonFollow console spam when looking up or down * revert a too-aggressive change * too aggressive again * Update CHANGELOG.md * Fixed missing changelog entry. * CMCL-622 * Backport: Bugfix: memory leak with PostProcessing if no PP layer is present on the camera * Backport: Bugfix: Cinemachine does not produce compiler error in unity editor versions older than 2020, when Input System package is installed. * Backport: Bugfix: Standalone profiler no longer crashed with CM. * backport: CMCL-779 * Fix part 2. Legacy type was not displayed when part of an array * CMCL-783: Timeline guard (#398) * Timeline guards added * Changelog * Package version bump * Changelog release date * Changelog fixes * version in core * Moved changelog line Co-authored-by: Gregory Labute <gregoryl@unity3d.com> Co-authored-by: Mark Visser <markv@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
CMCL-710: gimbal lock console spam when looking straight up or down in 3rdPersonFollow
Testing status
Documentation status
Technical risk
low
Comments to reviewers
See the repro project included in the fogbugz issue