Skip to content

AIRO-1765 Cleanup for ImageDefaultVisualizer #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2022
Merged

AIRO-1765 Cleanup for ImageDefaultVisualizer #263

merged 1 commit into from
Mar 3, 2022

Conversation

LaurieCheers-unity
Copy link
Contributor

Fixes:
Destroy textures when they're no longer in use
Reuse textures where possible
Display single-channel images as greyscale instead of red

@LaurieCheers-unity LaurieCheers-unity changed the title Cleanup for ImageDefaultVisualizer AIRO-1765 Cleanup for ImageDefaultVisualizer Mar 2, 2022
hyounesy
hyounesy approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@hyounesy hyounesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works.
Tested com.unity.robotics.visualizations#dev and the memory leak was noticable. after switching to com.unity.robotics.visualizations#ImageVisualizerMemoryLeak the issue was fixed.

@LaurieCheers-unity LaurieCheers-unity merged commit ea2665f into dev Mar 3, 2022
@LaurieCheers-unity LaurieCheers-unity deleted the ImageVisualizerMemoryLeak branch March 3, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyounesy hyounesy hyounesy approved these changes

@at669 at669 at669 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LaurieCheers-unity @hyounesy @at669