Skip to content

Conversation

@ritamerkl
Copy link
Collaborator

@ritamerkl ritamerkl commented Dec 17, 2025

Description

The documentation was wrong in stating that Tochscreens weren't supported on Linux, this PR changes this.
Ticket: ISX-2385

Testing status & QA

None.

Overall Product Risks

  • Complexity: Low
  • Halo Effect: Low

Comments to reviewers

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@u-pr-agent
Copy link
Contributor

u-pr-agent bot commented Dec 17, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅

ISX-2385 - Fully compliant

Compliant requirements:

  • Updated SupportedDevices.md to indicate "Yes" for Touchscreen support on Linux (3rd data column).
  • Added a corresponding entry to CHANGELOG.md.
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

The PR is a simple documentation fix and changelog update with no logic changes.
🏅 Score: 100

The PR correctly addresses the issue by updating the documentation table and includes the necessary changelog entry.
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected
  • Update review

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent

@u-pr-agent
Copy link
Contributor

u-pr-agent bot commented Dec 17, 2025

PR Code Suggestions ✨

No code suggestions found for the PR.

@ritamerkl ritamerkl requested review from JonMUnity and ekcoh December 17, 2025 10:44
@codecov-github-com
Copy link

codecov-github-com bot commented Dec 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff             @@
##           develop    #2304      +/-   ##
===========================================
- Coverage    77.95%   77.94%   -0.01%     
===========================================
  Files          477      476       -1     
  Lines        97419    97435      +16     
===========================================
+ Hits         75943    75948       +5     
- Misses       21476    21487      +11     
Flag Coverage Δ
inputsystem_MacOS_2022.3 5.54% <ø> (-0.01%) ⬇️
inputsystem_MacOS_2022.3_project 75.47% <ø> (-0.03%) ⬇️
inputsystem_MacOS_6000.0 5.32% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.0_project 77.36% <ø> (-0.06%) ⬇️
inputsystem_MacOS_6000.2 5.32% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.2_project 77.36% <ø> (-0.06%) ⬇️
inputsystem_MacOS_6000.3 5.32% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.3_project 77.36% <ø> (-0.06%) ⬇️
inputsystem_MacOS_6000.4 5.32% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.4_project 77.36% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.5 5.32% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.5_project 77.36% <ø> (-0.06%) ⬇️
inputsystem_Ubuntu_2022.3 5.54% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_2022.3_project 75.27% <ø> (-0.03%) ⬇️
inputsystem_Ubuntu_6000.0 5.32% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.0_project 77.16% <ø> (-0.06%) ⬇️
inputsystem_Ubuntu_6000.2 5.32% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.2_project 77.16% <ø> (-0.06%) ⬇️
inputsystem_Ubuntu_6000.3 5.32% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.3_project 77.16% <ø> (-0.06%) ⬇️
inputsystem_Ubuntu_6000.4 5.33% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.4_project 77.17% <ø> (-0.06%) ⬇️
inputsystem_Ubuntu_6000.5 5.33% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.5_project 77.17% <ø> (-0.06%) ⬇️
inputsystem_Windows_2022.3 5.54% <ø> (-0.01%) ⬇️
inputsystem_Windows_2022.3_project 75.60% <ø> (-0.03%) ⬇️
inputsystem_Windows_6000.0 5.32% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.0_project 77.49% <ø> (-0.05%) ⬇️
inputsystem_Windows_6000.2 5.32% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.2_project 77.49% <ø> (-0.06%) ⬇️
inputsystem_Windows_6000.3 5.32% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.3_project 77.49% <ø> (-0.06%) ⬇️
inputsystem_Windows_6000.4 5.32% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.4_project 77.49% <ø> (-0.05%) ⬇️
inputsystem_Windows_6000.5 5.32% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.5_project 77.49% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ritamerkl ritamerkl self-assigned this Dec 17, 2025
@ritamerkl ritamerkl merged commit 71886a6 into develop Dec 18, 2025
125 checks passed
@ritamerkl ritamerkl deleted the docs-linux-support-touchscreen branch December 18, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants