FIX: [ISXB-1713] autosave closes add control scheme ui element on save. #2268
Conversation
I still need to look into other solutions / look into if this fix is correct.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent |
![u-pr-agent[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/InputActionsEditorWindow.cs
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/InputActionsEditorWindow.cs
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/Views/ControlSchemesView.cs
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## develop #2268 +/- ##
===========================================
+ Coverage 76.70% 76.80% +0.09%
===========================================
Files 465 476 +11
Lines 87919 88651 +732
===========================================
+ Hits 67442 68089 +647
- Misses 20477 20562 +85 Flags with carried forward coverage won't be shown. Click here to find out more.
... and 25 files with indirect coverage changes 🚀 New features to boost your workflow:
|
We now just don't autosave in this case as there is no need.
There was a problem hiding this comment.
Looks okay to me! Thanks for working on it.
CC @ekcoh for viz, this fix seems to build up on my other idea of not saving during the sensitive moments in time. Not cool to be extending it, but what else could be done before our auto-save code is redesigned to be less crazy than it is now? :)
|
It still reproduces with project wide actions view but if it is complicated to fix I'd be fine with merging as is. Steps to repro: Open project settings -> input system view -> make sure you have a PWA asset if not make one -> make some changes (this window always uses auto save) -> start editing the control scheme as bug repro describes -> focus is lost 31.10.2025.-.Unity.322.mp4 |
Description
Fix an issue where the control scheme UI would close when pressing the + for adding a device type when there was a pending change to be auto saved.
Ticket:
https://jira.unity3d.com/browse/ISXB-1713
Testing status & QA
I have tested this manually in the editor on Unity version 6.000.1.5f1
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: