Skip to content

NEW: Code generated by the InputActionCodeGenerator, adding a new constructor with the parameter InputActionAsset. #1414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

KumoKyaku
Copy link

Description

Code generated by the InputActionCodeGenerator, adding a new constructor with the parameter InputActionAsset.

Changes made

  • Added a new constructor with the parameter InputActionAsset asset to generated class.
  • Re-generated existing actions sets to implement the new functionality.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as "Resolved" with next release version correctly set.
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@unity-cla-assistant
Copy link

unity-cla-assistant commented Oct 5, 2021

CLA assistant check
All committers have signed the CLA.

@jimon
Copy link
Contributor

jimon commented Oct 5, 2021

@KumoKyaku thanks for the contribution, could you please clarify what would be the use case for using a constructor with an asset? Current design is based on assumption of generated code being fully encapsulated, e.g. no assets are required to use it after the fact.

@jimon
Copy link
Contributor

jimon commented Oct 5, 2021

@DaveRune
Copy link

DaveRune commented Feb 8, 2023

How does this progress?
I have just written a reasonably substantial workaround due to the lack of functionality that this PR aimed to include.
Also in the file InputActionCodeGenerator.cs the very first to do is this.
"////TODO: option to allow referencing the original asset rather than embedding it"

@jfreire-unity jfreire-unity added the waiting-for-review The issue is scheduled to be reviewed by the Unity maintainers label Mar 3, 2023
@mitay-walle
Copy link

would be this ever implemented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-review The issue is scheduled to be reviewed by the Unity maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants