Fixed an issue where manipulating the color wheels in a volume component would reset the cursor every time. #985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent would reset the cursor every time.
alelievr
approved these changes
Jun 19, 2020
sebastienlagarde
approved these changes
Jun 19, 2020
|
Tested all color grading mode to be sure there is no other side effect. |
This was referenced Jun 19, 2020
JulienIgnace-Unity
added
backported-7.x
backported-8.x
and removed
needs-backport-7.x
needs-backport-8.x
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fixed an issue where manipulating the color wheels in a volume component would reset the cursor every time.
Fixes https://fogbugz.unity3d.com/f/cases/1255278/
@alelievr added you as a reviewer because I think I remember you updating my fix at some point. Just to make sure I did no regression.
Testing status
Tested the color wheel after the change. Also tested modifying (adding components etc) volume profiles with more than one inspector open (as well as the Default HDRP volume settings) at the same time to check if behaviour was consistent (the fix to this particular issue caused the color wheel bug).