Skip to content

Fixed an issue where static sky lighting would not be updated for a new scene until it's reloaded at least once. #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 19, 2020

Conversation

JulienIgnace-Unity
Copy link
Contributor

@JulienIgnace-Unity JulienIgnace-Unity commented Jun 19, 2020

Purpose of this PR

Fixed an issue where static sky lighting would not be updated for a new scene until it's reloaded at least once.

Fixes https://fogbugz.unity3d.com/f/cases/1256228/

@Unity-Technologies/gfx-qa-hdrp To fix this issue I had to revert and redo a fix done in this PR: #462 . Can you please make sure that both issues fixed by it at the time have not regressed back?
@RSlysz the problem was with "fixing" the env panel editor to use serialized properties for the profile. By doing that it bypassed logic in the setter... (there was actually a comment about that).


Testing status

Manually tested static sky with new scenes and manipulated it.

@sebastienlagarde
Copy link
Contributor

Tested various scenario:

  • tested the material preview, from existing Material or from new Material with high exposure sky: HDRI and surface gradient
  • Switched between different sky type: HDRI, gradient, PBS, disabling/Enabling sky, assign different sky in virtual environment, assign different static lighting None, current sky, different sky. With varying exposure.
  • Tested the scenario reported in the issue.

Merging based on this QA pass above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants