Skip to content

Fixed decal duplication when editing a prefab in context [2020.2] #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 19, 2020

Conversation

JulienIgnace-Unity
Copy link
Contributor

Purpose of this PR

This PR completes the work started in #789
It will fix decal duplication when editing the prefab in context.

This requires this ono PR before it can be merged: https://ono.unity3d.com/unity/unity/pull-request/108014/_/graphics/go-scenecullingmask

For testing purpose, the ono branch is graphics/go-scenecullingmask.

@JulienIgnace-Unity JulienIgnace-Unity requested review from sebastienlagarde and a team June 11, 2020 15:37
@sebastienlagarde sebastienlagarde changed the title Fixed decal duplication when editing a prefab in context. Fixed decal duplication when editing a prefab in context [Require C++] Jun 11, 2020
Copy link
Contributor

@JMargevics JMargevics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked prefab context mode. Decals are rendered perfectly now, no duplication or other issues ✅

@sebastienlagarde sebastienlagarde changed the title Fixed decal duplication when editing a prefab in context [Require C++] Fixed decal duplication when editing a prefab in context [2020.2] Jun 19, 2020
@sebastienlagarde sebastienlagarde changed the base branch from HDRP/staging to master June 19, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants