Skip to content

Fix raytracing keyword & static render state leak #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2020
Merged

Fix raytracing keyword & static render state leak #829

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37e969c
Fix raytracing keyword value
alelievr Jun 10, 2020
249203e
Fix static render state being modified and causing side effects
alelievr Jun 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions com.unity.render-pipelines.high-definition/Editor/Material/ShaderGraph/HDShaderPasses.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,8 @@ public static PassDescriptor GenerateMotionVectors(bool supportLighting)

RenderStateCollection GenerateRenderState()
{
var renderState = CoreRenderStates.MotionVectors;
var renderState = new RenderStateCollection();
renderState.Add(CoreRenderStates.MotionVectors);

if (!supportLighting)
{
Expand Down Expand Up @@ -1014,8 +1015,8 @@ public static class Defines
public static DefineCollection shadowHigh = new DefineCollection { {CoreKeywordDescriptors.Shadow, 2} };

// Raytracing Quality
public static DefineCollection raytracingLow = new DefineCollection { {RayTracingNode.GetRayTracingKeyword(), 0} };
public static DefineCollection raytracingHigh = new DefineCollection { {RayTracingNode.GetRayTracingKeyword(), 1} };
public static DefineCollection raytracingLow = new DefineCollection { {RayTracingNode.GetRayTracingKeyword(), 1} };
public static DefineCollection raytracingHigh = new DefineCollection { {RayTracingNode.GetRayTracingKeyword(), 0} };
}

#endregion
Expand Down