Skip to content

Hdrp/fix/cookie area light update #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2020
Merged

Hdrp/fix/cookie area light update #828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
547e954
Fixed area light cookie not used when a spot cookie is assigned
alelievr Jun 10, 2020
1e81abf
Updated changelog
alelievr Jun 10, 2020
919c8e3
Merge branch 'HDRP/staging' into HDRP/fix/cookie-area-light-update
sebastienlagarde Jun 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,6 +662,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fix inconsistencies with transparent motion vectors and opaque by allowing camera only transparent motion vectors.
- Fix reflection probe frame settings override
- Fixed certain shadow bias artifacts present in volumetric lighting (case 1231885).
- Fixed area light cookie not updated when switch the light type from a spot that had a cookie.

### Changed
- Improve MIP selection for decals on Transparents
Expand Down
3 changes: 2 additions & 1 deletion com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1486,7 +1486,8 @@ internal void GetLightData(CommandBuffer cmd, HDCamera hdCamera, HDShadowSetting
lightData.screenSpaceShadowIndex = (int)LightDefinitions.s_InvalidScreenSpaceShadow;
lightData.isRayTracedContactShadow = 0.0f;

if (lightComponent != null && lightComponent.cookie != null)
// lightComponent.cookie can't be used for area lights
if (lightComponent != null && lightComponent.cookie != null && lightType != HDLightType.Area)
{
switch (lightType)
{
Expand Down