Skip to content

Fix issue with dynamic resolution and CAS + issue with dynamic resolution updating while not in playmode #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 10, 2020
Merged

Fix issue with dynamic resolution and CAS + issue with dynamic resolution updating while not in playmode #827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4477a7
Make sure update of dynamic res happens only in game view and not whe…
FrancescoC-unity Jun 10, 2020
044fb44
changelog
FrancescoC-unity Jun 10, 2020
96821c4
Allow forced res to still be valid while not playing
FrancescoC-unity Jun 10, 2020
f0c1375
Merge branch 'HDRP/staging' into HDRP/fix-issue-with-dynamic-res-and-…
sebastienlagarde Jun 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion com.unity.render-pipelines.core/Runtime/Common/DynamicResolutionHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ static private float DefaultDynamicResMethod()

private void ProcessSettings(GlobalDynamicResolutionSettings settings)
{
m_Enabled = settings.enabled;
m_Enabled = settings.enabled && (Application.isPlaying || settings.forceResolution);
if (!m_Enabled)
{
m_CurrentFraction = 1.0f;
Expand Down
2 changes: 2 additions & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,6 +663,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fix reflection probe frame settings override
- Fixed certain shadow bias artifacts present in volumetric lighting (case 1231885).
- Fixed area light cookie not updated when switch the light type from a spot that had a cookie.
- Fixed issue with dynamic resolution updating when not in play mode.
- Fixed issue with Contrast Adaptive Sharpening upsample mode and preview camera.

### Changed
- Improve MIP selection for decals on Transparents
Expand Down
2 changes: 1 addition & 1 deletion com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1559,7 +1559,7 @@ protected override void Render(ScriptableRenderContext renderContext, Camera[] c
HDAdditionalCameraData hdCam;
if (camera.TryGetComponent<HDAdditionalCameraData>(out hdCam))
{
cameraRequestedDynamicRes = hdCam.allowDynamicResolution;
cameraRequestedDynamicRes = hdCam.allowDynamicResolution && camera.cameraType == CameraType.Game;

// We are in a case where the platform does not support hw dynamic resolution, so we force the software fallback.
// TODO: Expose the graphics caps info on whether the platform supports hw dynamic resolution or not.
Expand Down