Skip to content

Fix reflection probe framesettings override #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2020
Merged

Fix reflection probe framesettings override #796

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e97a6a6
Fix reflection probe framsettings override
adrien-de-tocqueville Jun 9, 2020
0bf0445
changelog
adrien-de-tocqueville Jun 9, 2020
6b476c2
Merge branch 'HDRP/staging' into HDRP/fix-probe-settings
sebastienlagarde Jun 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,6 +652,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fix an issue with the color intensity of emissive for performance rtgi
- Fixed issue with rendering being mostly broken when target platform disables VR.
- Workaround an issue caused by GetKernelThreadGroupSizes failing to retrieve correct group size.
- Fix reflection probe frame settings override

### Changed
- Improve MIP selection for decals on Transparents
Expand Down
7 changes: 0 additions & 7 deletions com.unity.render-pipelines.high-definition/Runtime/Utilities/ProbeSettingsUtilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,13 +108,6 @@ public static void ApplySettings(
cameraSettings.defaultFrameSettings = FrameSettingsRenderType.CustomOrBakedReflection;
break;
}

switch (settings.type)
{
case ProbeSettings.ProbeType.ReflectionProbe:
cameraSettings.customRenderingSettings = true;
break;
}
}

internal static void ApplyMirroredReferenceTransform(
Expand Down