Skip to content

Fix an issue with Fast memory code trying to access deleted resources when rendergraph is enabled #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Fix an issue with Fast memory code trying to access deleted resources when rendergraph is enabled #791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07584dc
Fix issue accessing already released targets for rendergraph
FrancescoC-unity Jun 9, 2020
a58368c
changelog
FrancescoC-unity Jun 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,6 +652,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fix an issue with the color intensity of emissive for performance rtgi
- Fixed issue with rendering being mostly broken when target platform disables VR.
- Workaround an issue caused by GetKernelThreadGroupSizes failing to retrieve correct group size.
- Fix issue with fast memory and rendergraph.

### Changed
- Improve MIP selection for decals on Transparents
Expand Down
6 changes: 5 additions & 1 deletion com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2206,7 +2206,11 @@ AOVRequestData aovRequest
hdCamera.BeginRender(cmd);
m_CurrentHDCamera = hdCamera;

SwitchRenderTargetsToFastMem(cmd, hdCamera);
// Render graph deals with Fast memory support in an automatic way.
if(!m_EnableRenderGraph)
{
SwitchRenderTargetsToFastMem(cmd, hdCamera);
}

if (m_RayTracingSupported)
{
Expand Down