[Draft] Lighting/probevolumes cleanup#756

Merged

sebastienlagarde merged 26 commits intoHDRP/stagingfrom

lighting/probevolumes-cleanup

Jun 10, 2020

Commits on Jun 9, 2020

Simplify EvaluateProbeVolumes interface and builtin SampleBakedGI code

Tobias Alexander Franke
authored and
pastasfuture
committed
Fix clearing of uninitialized GI

Tobias Alexander Franke
authored and
pastasfuture
committed
Added ProbeVolumesEncodingMode to ShaderOptions in ShaderConfig to allow users to configure their project to store and sample probe volumes as SH0 terms, SH1 terms, or SH2 terms, for different perf…
pastasfuture
committed
Probe Volumes: SH0, SH1, and SH2 evaluation based on ShaderConfig fully working now. Lots of additional cleanup tasks as well.
pastasfuture
committed
Probe Volumes: Instead of specifying AtlasWidth, AtlasHeight and AtlasDepth for probe volume atlas on HDRenderPipelineAsset, have user simply specify AtlasResolution and use for all axes. Same trea…
pastasfuture
committed
Probe Volumes: HDRenderPipelineAsset: Add memory usage information to UI and ensure we never allocate the ProbeVolumeAtlas or OctahedralDepthAtlas to be larger than k_MaxCacheSize
pastasfuture
committed
Probe Volumes: Bugfix for Probe Volume UI: Only display Additive blendmode warning if additive blend support is disabled in ShaderConfig
pastasfuture
committed
Probe Volumes: Bugfix: DataIsAssigned function needed in build as well.
pastasfuture
committed
Probe Volumes: Accumulate SH coefficients, and evaluate SH at normal after accumulation. This allows us to avoid 2x accumulations, 1 for forward normal, and 1 for backward (transmission) normal. Li…
pastasfuture
committed
Probe Volumes: Rename EvaluateProbeVolumes() to AccumulateProbeVolumes() to make it clear that evaluation happens in a following EvaluateProbeVolumeCoefficients() function.
pastasfuture
committed
Probe Volumes: Major cleanup to AccumulateProbeVolumes(), pulling out the majority of the logic into self contained supporting functions.
pastasfuture
committed
Probe Volumes: Add ShaderConfig.s_ProbeVolumesBilaterialFilteringMode and strip out octahedral depth logic and memory allocations when not in use.
pastasfuture
committed
Probe Volumes: Do not allocate or bake octahedral depth data in ProbeVolumeAsset if ShaderConfig does not enable octahedral depth bilateral filtering.
pastasfuture
committed
Probe Volumes: Always allocate and pass octahedralDepth array into GetAdditionalBakedProbes() because the API call without the octahedralDepth argument has been flagged as obsolete. In the future, …
pastasfuture
committed
Probe Volumes: Explicit ProbeVolumeAccumulateSphericalHarmonicsL0, L1, and L2 variants exist so we can choose to sample any order we want in any atlas configuration. i.e: sample L0 for vfx with L2 …
pastasfuture
committed
Probe Volumes: Add simple method for configuring what order of SH Probe Volumes is sampled at per shader (via a define before include).
pastasfuture
committed
Probe Volumes: Fix to ProbeVolumeUI string names
pastasfuture
committed
Probe Volumes: Move LightLoop::CreateBoxVolumeDataAndBound out parameters to end of args to match HDRP convention.
pastasfuture
committed
Probe Volumes: Remove redundant include from DebugDisplayProbeVolume.shader
pastasfuture
committed
Probe Volumes: Only support SH1 and SH2 atlas (SH0 was not needed). Change / cleanup payload data layout. Now SH0 and SH1 terms are stored in one float array, and SH2 quadratic terms are stored in …
pastasfuture
committed
Probe Volumes: Wrap supporting accumulation, evaluation, and fallback function calls into ProbeVolumeEvaluateSphericalHarmonics() function to hide static branches around SH order from LightLoop and…
pastasfuture
committed
Probe Volumes: Update SampleBakedGI() API (#759)

sebastienlagarde
and
pastasfuture
committed
Probe Volumes: Fix DebugViewTiles shader after updates to ProbeVolumeGetCountAndStart()
pastasfuture
committed
Probe Volumes: Set ShaderConfig evaluation mode to be disabled by default.
pastasfuture
committed
Probe Volumes: Update EvaluateOctahedralDepth function name to match surrounding code convention.
pastasfuture
committed

Commits on Jun 10, 2020

Probe Volumes: Fix up ShaderVariablesGlobal after naming conflict from pulling in lastest.
pastasfuture
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Draft] Lighting/probevolumes cleanup#756

[Draft] Lighting/probevolumes cleanup#756
sebastienlagarde merged 26 commits intoHDRP/stagingfrom
lighting/probevolumes-cleanup

Commits on Jun 9, 2020

Simplify EvaluateProbeVolumes interface and builtin SampleBakedGI code

Fix clearing of uninitialized GI

Added ProbeVolumesEncodingMode to ShaderOptions in ShaderConfig to allow users to configure their project to store and sample probe volumes as SH0 terms, SH1 terms, or SH2 terms, for different perf…

Probe Volumes: SH0, SH1, and SH2 evaluation based on ShaderConfig fully working now. Lots of additional cleanup tasks as well.

Probe Volumes: Instead of specifying AtlasWidth, AtlasHeight and AtlasDepth for probe volume atlas on HDRenderPipelineAsset, have user simply specify AtlasResolution and use for all axes. Same trea…

Probe Volumes: HDRenderPipelineAsset: Add memory usage information to UI and ensure we never allocate the ProbeVolumeAtlas or OctahedralDepthAtlas to be larger than k_MaxCacheSize

Probe Volumes: Bugfix for Probe Volume UI: Only display Additive blendmode warning if additive blend support is disabled in ShaderConfig

Probe Volumes: Bugfix: DataIsAssigned function needed in build as well.

Probe Volumes: Accumulate SH coefficients, and evaluate SH at normal after accumulation. This allows us to avoid 2x accumulations, 1 for forward normal, and 1 for backward (transmission) normal. Li…

Probe Volumes: Rename EvaluateProbeVolumes() to AccumulateProbeVolumes() to make it clear that evaluation happens in a following EvaluateProbeVolumeCoefficients() function.

Probe Volumes: Major cleanup to AccumulateProbeVolumes(), pulling out the majority of the logic into self contained supporting functions.

Probe Volumes: Add ShaderConfig.s_ProbeVolumesBilaterialFilteringMode and strip out octahedral depth logic and memory allocations when not in use.

Probe Volumes: Do not allocate or bake octahedral depth data in ProbeVolumeAsset if ShaderConfig does not enable octahedral depth bilateral filtering.

Probe Volumes: Always allocate and pass octahedralDepth array into GetAdditionalBakedProbes() because the API call without the octahedralDepth argument has been flagged as obsolete. In the future, …

Probe Volumes: Explicit ProbeVolumeAccumulateSphericalHarmonicsL0, L1, and L2 variants exist so we can choose to sample any order we want in any atlas configuration. i.e: sample L0 for vfx with L2 …

Probe Volumes: Add simple method for configuring what order of SH Probe Volumes is sampled at per shader (via a define before include).

Probe Volumes: Fix to ProbeVolumeUI string names

Probe Volumes: Move LightLoop::CreateBoxVolumeDataAndBound out parameters to end of args to match HDRP convention.

Probe Volumes: Remove redundant include from DebugDisplayProbeVolume.shader

Probe Volumes: Only support SH1 and SH2 atlas (SH0 was not needed). Change / cleanup payload data layout. Now SH0 and SH1 terms are stored in one float array, and SH2 quadratic terms are stored in …

Probe Volumes: Wrap supporting accumulation, evaluation, and fallback function calls into ProbeVolumeEvaluateSphericalHarmonics() function to hide static branches around SH order from LightLoop and…

Probe Volumes: Update SampleBakedGI() API (#759)

Probe Volumes: Fix DebugViewTiles shader after updates to ProbeVolumeGetCountAndStart()

Probe Volumes: Set ShaderConfig evaluation mode to be disabled by default.

Probe Volumes: Update EvaluateOctahedralDepth function name to match surrounding code convention.

Commits on Jun 10, 2020

Probe Volumes: Fix up ShaderVariablesGlobal after naming conflict from pulling in lastest.

[Draft] Lighting/probevolumes cleanup#756sebastienlagarde merged 26 commits intoHDRP/stagingUnity-Technologies/Graphics:HDRP/stagingfrom lighting/probevolumes-cleanupUnity-Technologies/Graphics:lighting/probevolumes-cleanupCopy head branch name to clipboard

Commits

Commits on Jun 9, 2020

Commits on Jun 10, 2020

[Draft] Lighting/probevolumes cleanup#756
sebastienlagarde merged 26 commits intoHDRP/stagingfrom
lighting/probevolumes-cleanup